Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refer to "macOS", not "macOS X". #9704

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Refer to "macOS", not "macOS X". #9704

merged 1 commit into from
Sep 5, 2023

Conversation

waywardmonkeys
Copy link
Contributor

Objective

  • Refer to OSes by their correct name.

Solution

  • Do so.

@waywardmonkeys
Refer to "macOS", not "macOS X".
7df793d 
# Objective

- Refer to OSes by their correct name.

## Solution

- Do so.
alice-i-cecile
alice-i-cecile approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be the only occurrence :)

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 5, 2023
@waywardmonkeys
Copy link
Contributor Author

This appears to be the only occurrence :)

Yep! I'd looked something up, saw this and then searched pretty exhaustively for a number of (incorrect) variations and these were the only ones I found. :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 5, 2023
Merged via the queue into bevyengine:main with commit cac8442 Sep 5, 2023
24 checks passed
@waywardmonkeys waywardmonkeys deleted the macos-not-x branch September 13, 2023 06:50
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@waywardmonkeys
Refer to "macOS", not "macOS X". (bevyengine#9704)
6c8d048 
# Objective

- Refer to OSes by their correct name.

## Solution

- Do so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMS55 JMS55 JMS55 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waywardmonkeys @alice-i-cecile @JMS55