Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment in scene example FromResources #9743

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Fix comment in scene example FromResources #9743

merged 3 commits into from
Sep 11, 2023

Conversation

A-Walrus
Copy link
Contributor

Comment references non existent FromResources instead of FromWorld

nicopap
nicopap reviewed Sep 10, 2023
View reviewed changes
examples/scene/scene.rs Outdated Show resolved Hide resolved
@nicopap nicopap added C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Reflection Runtime information about types and removed C-Docs An addition or correction to our documentation labels Sep 10, 2023
@A-Walrus @nicopap
Add backticks
34a2c74 
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
mockersf
mockersf reviewed Sep 10, 2023
View reviewed changes
examples/scene/scene.rs Outdated Show resolved Hide resolved
@alice-i-cecile @mockersf
Count the number of derives
e32aa54 
Co-authored-by: François <mockersf@gmail.com>
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 11, 2023
Merged via the queue into bevyengine:main with commit 1a7fc57 Sep 11, 2023
21 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@A-Walrus @nicopap
@alice-i-cecile @mockersf
Fix comment in scene example FromResources (bevyengine#9743)
1c8c97d 
Comment references non existent `FromResources` instead of `FromWorld`

---------

Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: François <mockersf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopap nicopap nicopap approved these changes

@mockersf mockersf mockersf left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@A-Walrus @alice-i-cecile @mockersf @nicopap