"serialize" feature no longer enables the optional "bevy_scene" feature if it's not enabled from elsewhere #9803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
requested changes
Sep 14, 2023
There was a problem hiding this comment.
I would prefer to change it here:
bevy/crates/bevy_internal/Cargo.toml
Line 64 in 90b741d
bevy_scene is an optional crate, but it's not possible to enable serialize without it.
If you change the line linked above to
serialize = ["bevy_core/serialize", "bevy_input/serialize", "bevy_time/serialize", "bevy_window/serialize", "bevy_transform/serialize", "bevy_math/serialize", "bevy_scene?/serialize"]
it should work
|
Thank you for the helpful pointer! I didn't think to look deeper for the origin of the feature flag, and that Cargo feature is so handy. |
nxsaken
changed the title
mockersf
approved these changes
Sep 14, 2023
tim-blackbird
approved these changes
Sep 14, 2023
james7132
approved these changes
Sep 14, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…re if it's not enabled from elsewhere (bevyengine#9803) # Objective Fixes bevyengine#9787 ## Solution ~~"serialize" feature enables "bevy_asset" now~~ "serialize" feature no longer enables the optional "bevy_scene" feature if it's not enabled from elsewhere (thanks to @mockersf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #9787
Solution
"serialize" feature enables "bevy_asset" now"serialize" feature no longer enables the optional "bevy_scene" feature if it's not enabled from elsewhere (thanks to @mockersf)