Fix the clippy::explicit_iter_loop lint
#9834
Conversation
JoJoJet
added
the
C-Code-Quality
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Once you fix merge conflicts I'll merge :p |
I was very confused for a second, but we used to use Do we want to add that back in now? iirc this should be possible now after #9583 (and this PR's changes). |
|
Sure I can add the warning back -- seems reasonable. |
|
On second thought, let's not add the warning yet. This suggestion is makes it worse. 373 | for (access, _) in self.0.iter() {
| ^^^^^^^^^^^^^ help: to write this more concisely, try: `&*self.0`Seems like the suggestion will be fixed in the next clippy release (rust-lang/rust-clippy#11074), so we can enable the warning then. |
# Objective
Replace instances of
```rust
for x in collection.iter{_mut}() {
```
with
```rust
for x in &{mut} collection {
```
This also changes CI to no longer suppress this lint. Note that since
this lint only shows up when using clippy in pedantic mode, it was
probably unnecessary to suppress this lint in the first place.
Objective
Replace instances of
with
This also changes CI to no longer suppress this lint. Note that since this lint only shows up when using clippy in pedantic mode, it was probably unnecessary to suppress this lint in the first place.