Add some more docs for bevy_text. #9873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ickshonpe
suggested changes
Sep 20, 2023
alice-i-cecile
added
C-Docs
waywardmonkeys
force-pushed
the
bevy-text-doc-additions
branch
from
3ad819d to
cf7630c
Compare
alice-i-cecile
added
the
M-Needs-Migration-Guide
|
Sorry for the delay in addressing the feedback here. I think I've done it now though. |
alice-i-cecile
approved these changes
Oct 16, 2023
mockersf
reviewed
Oct 16, 2023
waywardmonkeys
force-pushed
the
bevy-text-doc-additions
branch
from
cf7630c to
5ddd715
Compare
|
By the way, in the future can you make more commits rather than amending and force-pushing when addressing feedback? Not a big deal, but it makes it much easier to check how the feedback was addressed and we squash on merge anyways. |
|
Just checking in on this to see if there's anything left for me to do. |
|
Nothing else: let me try and wrangle a second reviewer :) |
JMS55
approved these changes
Oct 27, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective - Have more docs for `bevy_text` to avoid reading the source code for some things. ## Solution - Add some additional docs. ## Changelog - `TextSettings.max_font_atlases` in `bevy_text` has been renamed to ` TextSettings.soft_max_font_atlases`. ## Migration Guide - Usages of `TextSettings.max_font_atlases` from `bevy_text` must be changed to `TextSettings.soft_max_font_atlases`.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Have more docs for `bevy_text` to avoid reading the source code for some things. ## Solution - Add some additional docs. ## Changelog - `TextSettings.max_font_atlases` in `bevy_text` has been renamed to ` TextSettings.soft_max_font_atlases`. ## Migration Guide - Usages of `TextSettings.max_font_atlases` from `bevy_text` must be changed to `TextSettings.soft_max_font_atlases`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_textto avoid reading the source code for some things.Solution
Changelog
TextSettings.max_font_atlasesinbevy_texthas been renamed toTextSettings.soft_max_font_atlases.Migration Guide
TextSettings.max_font_atlasesfrombevy_textmust be changed toTextSettings.soft_max_font_atlases.