Allow other plugins to create renderer resources #9925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalekiRe
approved these changes
Sep 26, 2023
mockersf
approved these changes
Sep 26, 2023
|
works for me on macOS, iOS, Android, WebGL2 and WebGPU |
superdump
reviewed
Sep 26, 2023
crates/bevy_render/src/settings.rs
Outdated
| @@ -93,6 +96,45 @@ impl Default for WgpuSettings { | |||
| } | |||
| } | |||
|
|
|||
| /// An enum describing how the renderer will initialize resources. This is used when creating the [`RenderPlugin`](crate::RenderPlugin). | |||
| pub enum RenderSettings { | |||
There was a problem hiding this comment.
The manual mode doesn't contain settings. @mockersf suggested calling it RenderCreation instead. I much prefer that. With manual creation you provide the handles. With automatic, you provide the settings.
And I think maybe the Default trait can be derived if you annotate the Automatic variant with #[default], right? If not, keep the manual implementation.
There was a problem hiding this comment.
the #[default] attribute can only be used on unit variants
superdump
requested changes
Sep 26, 2023
superdump
reviewed
Sep 26, 2023
superdump
requested changes
Sep 26, 2023
Co-authored-by: Robert Swain <robert.swain@gmail.com>
superdump
approved these changes
Sep 26, 2023
auto-merge was automatically disabled
September 26, 2023 19:15
Head branch was pushed to by a user without write access
superdump
approved these changes
Sep 26, 2023
|
I could be wrong, but should the migration guide be updated to reflect RenderCreation vs RenderSettings? |
43 tasks
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
This is a duplicate of bevyengine#9632, it was created since I forgot to make a new branch when I first made this PR, so I was having trouble resolving merge conflicts, meaning I had to rebuild my PR. # Objective - Allow other plugins to create the renderer resources. An example of where this would be required is my [OpenXR plugin](https://github.com/awtterpip/bevy_openxr) ## Solution - Changed the bevy RenderPlugin to optionally take precreated render resources instead of a configuration. ## Migration Guide The `RenderPlugin` now takes a `RenderCreation` enum instead of `WgpuSettings`. `RenderSettings::default()` returns `RenderSettings::Automatic(WgpuSettings::default())`. `RenderSettings` also implements `From<WgpuSettings>`. ```rust // before RenderPlugin { wgpu_settings: WgpuSettings { ... }, } // now RenderPlugin { render_creation: RenderCreation::Automatic(WgpuSettings { ... }), } // or RenderPlugin { render_creation: WgpuSettings { ... }.into(), } ``` --------- Co-authored-by: Malek <pocmalek@gmail.com> Co-authored-by: Robert Swain <robert.swain@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #9632, it was created since I forgot to make a new branch when I first made this PR, so I was having trouble resolving merge conflicts, meaning I had to rebuild my PR.
Objective
Solution
Migration Guide
The
RenderPluginnow takes aRenderCreationenum instead ofWgpuSettings.RenderSettings::default()returnsRenderSettings::Automatic(WgpuSettings::default()).RenderSettingsalso implementsFrom<WgpuSettings>.