-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI node outlines #9931
Merged
Merged
UI node outlines #9931
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
939411e
Adds support for outlines to Bevy UI.
ickshonpe f2a5595
Use `&Outline` query not `Ref<Outline>` in `resolve_outlines_system`
ickshonpe 0e82b9e
Outline width should be resolved with `max(0)` not `min(0)`.
ickshonpe 53a5e9f
Implement clipping for outlines. Outlines are drawn outside out of a …
ickshonpe cbdbf85
cargo fmt --all
ickshonpe 0d9df14
Fixed broken doc comment link
ickshonpe 677dcda
replaced `map-flatten` with `and_then` in `extract_uinode_outlines`
ickshonpe 472c14f
removed unnecessary semicolon
ickshonpe fd63961
Allow `Outline`s to be drawn with an offset:
ickshonpe a01e290
added examples to the doc comments for `Outline`
ickshonpe 975813b
edit comments
ickshonpe 7bf07c7
Merge branch 'main' into ui-node-outlines
ickshonpe 39b390e
fixed doc comment example errors
ickshonpe 8cd8e55
fixed doc comments
ickshonpe 32c6c09
comments fixed again
ickshonpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come you're calling
bypass_change_detection
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text system queries for changes to
Node
so it can recompute the text layout on changes to the UI node's size.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, do we not care about detecting changes to the
outline_width
andoutline_offset
fields?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at the moment. Maybe we could have a separate component for every property but it doesn't seem very tractable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I'd put a comment here describing that we don't care about change detection for these fields because they're private and only used as a cache.