Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming coherence for cameras #995

Merged
merged 2 commits into from
Dec 3, 2020
Merged

naming coherence for cameras #995

merged 2 commits into from
Dec 3, 2020

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 3, 2020

Just something that irked me for a while, but not sure if it's worthy of a breaking change...

Basically, it's renaming UiCameraBundle to CameraUiBundle, to be aligned with Camera2dBundle and Camera3dBundle

While at it I also changed a few internals const/strings to be coherent

Feel free to close, I can live with it...

Copy link
Contributor

@ambeeeeee ambeeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the renaming is good for consistency reasons, especially the underscores in the consts.

@cart
Copy link
Member

cart commented Dec 3, 2020

Yeah consistency is good. My rationale for them being different was:

  1. I would prefer the XCamera naming convention (ex: UiCamera)
  2. Rust doesn't allow type names to start with numbers (ex: 2dCamera is invalid)
  3. The "preferred" XCamera is the "default", which we override when rust's rules get in our way

I'm cool with these changes though.

@cart cart merged commit 59d98de into bevyengine:master Dec 3, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
@mockersf mockersf deleted the camera branch April 27, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants