Moved fq_std from bevy_reflect_derive to bevy_macro_utils
#9956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
alice-i-cecile
approved these changes
Sep 29, 2023
MrGVSV
approved these changes
Sep 29, 2023
MrGVSV
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Sep 29, 2023
Added missing documentation, added `warn(missing_docs)`, and `deny(unsafe)` as standard best-practice.
|
I've made the changes requested by @james7132 which increase the overall quality of |
james7132
approved these changes
Oct 2, 2023
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
…engine#9956) # Objective - Fixes bevyengine#9363 ## Solution Moved `fq_std` from `bevy_reflect_derive` to `bevy_macro_utils`. This does make the `FQ*` types public where they were previously private, which is a change to the public-facing API, but I don't believe a breaking one. Additionally, I've done a basic QA pass over the `bevy_macro_utils` crate, adding `deny(unsafe)`, `warn(missing_docs)`, and documentation where required.
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
…engine#9956) # Objective - Fixes bevyengine#9363 ## Solution Moved `fq_std` from `bevy_reflect_derive` to `bevy_macro_utils`. This does make the `FQ*` types public where they were previously private, which is a change to the public-facing API, but I don't believe a breaking one. Additionally, I've done a basic QA pass over the `bevy_macro_utils` crate, adding `deny(unsafe)`, `warn(missing_docs)`, and documentation where required.
regnarock
pushed a commit
to regnarock/bevy
that referenced
this pull request
Oct 13, 2023
…engine#9956) # Objective - Fixes bevyengine#9363 ## Solution Moved `fq_std` from `bevy_reflect_derive` to `bevy_macro_utils`. This does make the `FQ*` types public where they were previously private, which is a change to the public-facing API, but I don't believe a breaking one. Additionally, I've done a basic QA pass over the `bevy_macro_utils` crate, adding `deny(unsafe)`, `warn(missing_docs)`, and documentation where required.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…engine#9956) # Objective - Fixes bevyengine#9363 ## Solution Moved `fq_std` from `bevy_reflect_derive` to `bevy_macro_utils`. This does make the `FQ*` types public where they were previously private, which is a change to the public-facing API, but I don't believe a breaking one. Additionally, I've done a basic QA pass over the `bevy_macro_utils` crate, adding `deny(unsafe)`, `warn(missing_docs)`, and documentation where required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
fq_stdmodule should be moved tobevy_macro_utils#9363Solution
Moved
fq_stdfrombevy_reflect_derivetobevy_macro_utils. This does make theFQ*types public where they were previously private, which is a change to the public-facing API, but I don't believe a breaking one. Additionally, I've done a basic QA pass over thebevy_macro_utilscrate, addingdeny(unsafe),warn(missing_docs), and documentation where required.