Import the second UV map if present in glTF files. #9992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superdump
requested changes
Oct 2, 2023
IceSentry
approved these changes
Oct 2, 2023
|
Oh oops, looked like I missed a spot (I was testing with a custom shader so that didn't show up). Should be fixed now. |
Conventionally, the second UV map (`TEXCOORD1`, `UV1`) is used for lightmap UVs. This commit allows Bevy to import them, so that a custom shader that applies lightmaps can use those UVs if desired. Note that this doesn't actually apply lightmaps to Bevy meshes; that will be a followup. It does, however, open the door to future Bevy plugins that implement baked global illumination.
|
Need to modify prepass_io.wgsl as well maybe |
alice-i-cecile
added
A-Rendering
I don't think so, because I didn't update the prepass vertex bindings. I didn't see any need for the prepass to have access to UV1. |
|
The prepass uses the same vertex buffer though, right? Idk, maybe it doesn't actually cause issues. Idk how bevy setups up the vertex attributes off the top of my head. |
|
Yeah, I don't think it causes any issues because the mesh attributes are referred to by name inside Bevy. |
|
This was a longstanding missing feature. Consider searching the bug tracker. I think there is at least a couple issues that can be closed when this gets merged. |
superdump
approved these changes
Oct 2, 2023
|
The prepass uses it's own vertex layout, so it doesn't need to be updated for this |
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Is this limited to only uv1? As mentioned in the other ticket, exporting lightmaps from unreal seem to use several uv1 maps for reasons I don't really understand tbh (at least UV1-4) |
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Oct 3, 2023
Conventionally, the second UV map (`TEXCOORD1`, `UV1`) is used for lightmap UVs. This commit allows Bevy to import them, so that a custom shader that applies lightmaps can use those UVs if desired. Note that this doesn't actually apply lightmaps to Bevy meshes; that will be a followup. It does, however, open the door to future Bevy plugins that implement baked global illumination. ## Changelog ### Added The Bevy glTF loader now imports a second UV channel (`TEXCOORD1`, `UV1`) from meshes if present. This can be used by custom shaders to implement lightmapping.
43 tasks
regnarock
pushed a commit
to regnarock/bevy
that referenced
this pull request
Oct 13, 2023
Conventionally, the second UV map (`TEXCOORD1`, `UV1`) is used for lightmap UVs. This commit allows Bevy to import them, so that a custom shader that applies lightmaps can use those UVs if desired. Note that this doesn't actually apply lightmaps to Bevy meshes; that will be a followup. It does, however, open the door to future Bevy plugins that implement baked global illumination. ## Changelog ### Added The Bevy glTF loader now imports a second UV channel (`TEXCOORD1`, `UV1`) from meshes if present. This can be used by custom shaders to implement lightmapping.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
Conventionally, the second UV map (`TEXCOORD1`, `UV1`) is used for lightmap UVs. This commit allows Bevy to import them, so that a custom shader that applies lightmaps can use those UVs if desired. Note that this doesn't actually apply lightmaps to Bevy meshes; that will be a followup. It does, however, open the door to future Bevy plugins that implement baked global illumination. ## Changelog ### Added The Bevy glTF loader now imports a second UV channel (`TEXCOORD1`, `UV1`) from meshes if present. This can be used by custom shaders to implement lightmapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conventionally, the second UV map (
TEXCOORD1,UV1) is used for lightmap UVs. This commit allows Bevy to import them, so that a custom shader that applies lightmaps can use those UVs if desired.Note that this doesn't actually apply lightmaps to Bevy meshes; that will be a followup. It does, however, open the door to future Bevy plugins that implement baked global illumination.
Changelog
Added
The Bevy glTF loader now imports a second UV channel (
TEXCOORD1,UV1) from meshes if present. This can be used by custom shaders to implement lightmapping.