Skip to content

Factor out extension logic #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2025
Merged

Factor out extension logic #8

merged 2 commits into from
Aug 14, 2025

Conversation

cart
Copy link
Member

@cart cart commented Aug 14, 2025

Factor out extension logic to allow consumers to continue owning instance and device setup. This will enable bevyengine/bevy#19864 to use bevyengine/bevy#20565.

@cart cart mentioned this pull request Aug 14, 2025
Merged
JMS55
JMS55 requested changes Aug 14, 2025
View reviewed changes
Copy link
Collaborator

@JMS55 JMS55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approach looks good to me. Hopefully we get a new wgpu API and can delete the create instance/device methods, and just have the user set a callback in the backend options.

@alice-i-cecile alice-i-cecile requested a review from JMS55 August 14, 2025 21:50
@cart cart added this pull request to the merge queue Aug 14, 2025
Merged via the queue into main with commit 1c867e8 Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JMS55 JMS55 JMS55 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cart @JMS55