Opt-in raw vulkan initialization with hooks #20565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
added
C-Feature
|
You added a new feature but didn't update the readme. Please run |
alice-i-cecile
added
the
S-Needs-Review
cart
commented
Aug 14, 2025
tychedelia
approved these changes
Aug 14, 2025
JMS55
reviewed
Aug 14, 2025
JMS55
reviewed
Aug 14, 2025
JMS55
reviewed
Aug 14, 2025
JMS55
approved these changes
Aug 14, 2025
tychedelia
reviewed
Aug 14, 2025
JMS55
reviewed
Aug 14, 2025
Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
JMS55
approved these changes
Aug 14, 2025
JMS55
added
S-Ready-For-Final-Review
tychedelia
reviewed
Aug 15, 2025
| &mut additional_vulkan_features, | ||
| ) | ||
| .await | ||
| .unwrap(); |
There was a problem hiding this comment.
Realize this is explicitly is stated to force the Vulkan instance, but we could fallback to the regular init here with a warning instead of unwrapping.
| &device_descriptor.memory_hints, | ||
| Some(Box::new(|mut args| { | ||
| for callback in &settings.create_device_callbacks { | ||
| (callback)(&mut args, &raw_adapter, additional_features); |
There was a problem hiding this comment.
Long term, we also need access to &mut World here in order to initialize additional resources (additional queues, etc).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 31, 2025
#20565 broke compiling with `--all-features` on macos. Add the `vulkan-portability` feature to `bevy_render` required to make vulkan compile with wgpu on mac. Co-authored-by: François Mockers <francois.mockers@vleue.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently registering additional required Vulkan features requires either hard-coding them into
bevy_render(see the current DLSS proposal), or forcing the plugin to take full manual control over wgpu initialization. Neither is an acceptable or scalable option for a modular engine like Bevy.Solution
raw_vulkan_initCargo feature, that when enabled switches to wgpu's raw Vulkan init path, which accepts callbacks that allow checking and requiring additional Vulkan features.WgpuRawVulkanInitSettingsresource, which provides wgpu Vulkan Instance and Device init callbacks, which can be used to detect and register vulkan features.AdditionalVulkanFeaturesresource, which is inserted into the RenderApp at the same time that the RenderDevice is.This enables plugins to register initialization callbacks, which must happen before RenderPlugin. They can then feed off of
AdditionalVulkanFeatures, after the renderer is initialized, to detect if a given feature is supported.Due to the current lifecycles, this is best accomplished with either:
Plugin::build()access to render device state, which needs to be registered after RenderPlugin to have access. The proposed DLSS feature needs this pattern.With deferred plugin init, we could remove the need for this split.