add Lua burnblow fallback "over range" and "leash" customparams #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethDGamre
added
the
Awaiting GDT Approval
SethDGamre
removed
the
Awaiting GDT Approval
SethDGamre
force-pushed
the
projectileLeashRange
branch
from
90d9309
to
77a1905
Compare
SethDGamre
changed the title
|
why not just adjust flighttime for torpedoes? |
doesn't fix the original issue of bonus range from the drop distance of the torpedo. That would cause the torpedo to die before it reaches its target if adjusted for the desired range. It's a pile of poopy. Gadget's been rewritten to instead take care of unintentional range hax for rockets and starburst missile launchers and whatever else might be wanted. Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the gadget originally intended to fix torpedo bombers has become more about preventing overrange in general. The leash functionality is still there too. Quite performant. First I'd like to add the gadget and then give units the customparam in a separate PR