Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switching among buildmenu and gridmenu. #3961

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

saurtron
Copy link
Contributor

@saurtron saurtron commented Nov 23, 2024

Work done

  • Fixes problems when switching between grid and buildmenu.

Explanation

  • Both use the same global WG['buildmenu']. It will be set to nil by both on Shutdown and setup with Initialize, so this really needs DisableWidget to run immediately, and before WG['buildmenu'] is created. Otherwise it will get destroyed either in the middle of Initialize or afterwards by the other widget (they're fighting for the same global).
  • Seems buildmenu->gridmenu broke with the new queued DisableWidget that will make shutdown run after initialize is done here. Looks like gridmenu->buildmenu was broken since some time (jun-2024 with 30cac26).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant