346 Undefined denominators return No data #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan-bes
approved these changes
Apr 20, 2020
merge in latest dev to feature branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
346 - Some denominator values display as "undefined" in Disaster Response dashboard group report
Changes:
Added a check in formatter that if denominator is undefined return 'No data'.
Not sure if this is the correct place to do this? Could just return value (or at least check value is non-zero), but if we are expecting a fraction and denominator isn't supplied then we can assume something has gone wrong and better to display 'No data' than incorrect data?
Screenshots:
Relevant screenshots for this PR can be found here: https://github.com/beyondessential/tupaia-backlog/issues/346#issuecomment-682310694