Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN-1112: Bump moment-timezone to ≥0.5.35 #5482

Merged
merged 10 commits into from
Mar 20, 2024
Merged

Conversation

jaskfla
Copy link
Contributor

@jaskfla jaskfla commented Mar 8, 2024

Issue RN-1112: Bump moment-timezone to ≥0.5.35

Warning

A little nervous about this one. The Flight.test.js test suite in web-config-server threw a TypeError saying moment.tz() is not a function. Fixed the test by changing import moment from 'moment' to import moment from 'moment-timezone'. The only other module which I think might be affected is periodGranularities.js, but changing that to import from moment-timezone causes a TypeScript build error.

Changes

Changes since 0.5.14

0.5.45 2024-02-04
Updated data to IANA TZDB 2024a.

0.5.44 2023-12-29
Updated data to IANA TZDB 2023d.
Fixed .valueOf() to return NaN for invalid zoned objects (matching default moment) #1082.
Performance improvements:
Use binary search when looking up zone information #720.
Avoid redundant checks in tz.guess().
Avoid redundant getZone() calls in .tz().

0.5.43 2023-03-31
Updated data to IANA TZDB 2023c

0.5.42 2023-03-24
Updated data to IANA TZDB 2023b

0.5.41 2023-02-25
Updated moment npm dependency to 2.29.4 to remove automated warnings about insecure dependencies.
Moment Timezone still works with core Moment 2.9.0 and higher.
Updated all dev dependencies including UglifyJS, which produces the minified builds.
Added deprecation warning to the pre-built moment-timezone-with-data-2012-2022 bundles #1035.
Use the rolling moment-timezone-with-data-10-year-range files instead.

0.5.40 2022-12-11
Updated data to IANA TZDB 2022g

0.5.39 2022-11-13
Updated data to IANA TZDB 2022f

0.5.38 2022-10-15
Updated data to IANA TZDB 2022e
Added moment.tz.dataVersion property to TypeScript definitions #930
Removed temporary .tar.gz files from npm releases #1000

0.5.37 2022-08-25
Re-publish npm package, because of extra folder present in 0.5.36, check
moment/moment-timezone#999

0.5.36 2022-08-25
IANA TZDB 2022c
improvements/fixes to data pipeline

0.5.35 2022-08-23
Fix command injection in data pipeline GHSA-56x4-j7p9-fcf9
Fix cleartext transmission of sensitive information GHSA-v78c-4p63-2j6c

Thanks to the OpenSSF Alpha-Omega project for reporting these!

0.5.34 2021-11-10
Updated data to IANA TZDB 2021e

0.5.33 2021-02-06
Updated data to IANA TZDB 2021a

0.5.32 2020-11-14
Updated data to IANA TZDB 2020d

0.5.31 2020-05-16
Fixed Travis builds for Node.js 4 and 6

0.5.30 2020-05-16
Updated data to IANA TZDB 2020a
Fixed typescript definitions

NOTE: You might need to un-install @types/moment-timezone. Check
moment/moment-timezone#858 for more info

0.5.29 2020-05-16
Merged fix of es6 module loading issue moment/moment-timezone@1fd4234
Merged PR with typescript declarations moment/moment-timezone@ed529ea
Merged fixes to changelog moment/moment-timezone@adb7d7b

0.5.28 2020-02-21
Merged pull request #410 from @adgrace:
Added a method moment.tz.zonesForCountry(country_code) which returns all timezones for the country
Added a method moment.tz(timezone_id).countries() to get countries for some time zone
Added a method moment.tz.countries() to get all country codes
And as you know moment.tz.zones() already exists

0.5.27 2019-10-14
Updated data to IANA TZDB 2019c

0.5.26 2019-06-06
Updated data to IANA TZDB 2019b
Fix: stabilize Array.sort #762

0.5.25 2019-04-17
Fix moment.tz.dataVersion to return 2019a #742
Update path in bower.json

0.5.24 2019-04-17
Updated data to IANA TZDB 2019a #737
Start shipping both a 1970-1930 file and a rolling 10-year file #614 #697
Fixed bug where _z time zone name was not cleared with .local() or .utcOffset(offset) #738

0.5.23 2018-10-28
Fix minor issue with tz guessing in Russia #691

0.5.22 2018-10-28
Updated data to IANA TZDB 2018g #689
Fix issue with missing LMT entries for some zones, and fix data builds on Linux and Windows #308

0.5.21 2018-06-23
Bugfix: revert breaking change introduced in 0.5.18

0.5.20 2018-06-18
Bugfix: accidentally commented code

0.5.19 2018-06-18
Revert: moved moment to peerDependencies

0.5.18 2018-06-18
Return error when timezone name is not a string.
Moved moment to peerDependencies #628
Prefer nodejs to amd declaration #573

0.5.17 2018-05-12
Updated data to IANA TZDB 2018d. #616

0.5.16 2018-04-18
Fixed Etc/UTC timezone recognition, updated tests. #599
Updated minified files to contain IANA TZDB 2018d data

0.5.15 2018-04-17
Updated data to IANA TZDB 2018d. #596

@jaskfla jaskfla added the dependencies Pull requests that update a dependency file label Mar 14, 2024
@jaskfla jaskfla changed the title RN-1112: Bump moment-timezone to 0.5.45 RN-1112: Bump moment-timezone to ≤0.5.35 Mar 15, 2024
@jaskfla jaskfla changed the title RN-1112: Bump moment-timezone to ≤0.5.35 RN-1112: Bump moment-timezone to ≥0.5.35 Mar 15, 2024
Copy link
Contributor

@alexd-bes alexd-bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I think this will be okay, but we will find out in regression testing anyway

@jaskfla jaskfla merged commit 81e314e into dev Mar 20, 2024
42 checks passed
@jaskfla jaskfla deleted the rn-1112-bump-moment-timezone branch March 20, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants