Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): adds NoopMeter implementation #7

Closed
wants to merge 11 commits into from
Closed

Conversation

bg451
Copy link
Owner

@bg451 bg451 commented Sep 17, 2019

Resolves open-telemetry#264

Which problem is this PR solving?

Short description of the changes


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #7 into master will decrease coverage by 0.08%.
The diff coverage is 98.03%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage    98.9%   98.82%   -0.09%     
==========================================
  Files          66       71       +5     
  Lines        2651     2884     +233     
  Branches      175      187      +12     
==========================================
+ Hits         2622     2850     +228     
- Misses         29       34       +5
Impacted Files Coverage Δ
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <ø> (ø) ⬆️
.../opentelemetry-node-tracer/test/NodeTracer.test.ts 100% <ø> (ø) ⬆️
...kages/opentelemetry-basic-tracer/test/Span.test.ts 100% <100%> (ø) ⬆️
...ges/opentelemetry-exporter-jaeger/src/transform.ts 100% <100%> (ø) ⬆️
packages/opentelemetry-core/src/trace/NoopSpan.ts 100% <100%> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <100%> (ø) ⬆️
...pentelemetry-core/src/platform/node/performance.ts 100% <100%> (ø)
...ages/opentelemetry-core/src/platform/node/index.ts 100% <100%> (ø) ⬆️
...ckages/opentelemetry-core/test/common/time.test.ts 100% <100%> (ø)
...ckages/opentelemetry-core/src/metrics/NoopMeter.ts 100% <100%> (ø)
... and 9 more

mayurkale22 and others added 3 commits September 18, 2019 16:37
* feat(zipkin-exporter): implement

* fix(zipkin): use time fns

* refactor(exporter-zipkin): linter fix
@bg451 bg451 closed this Sep 19, 2019
@bg451 bg451 deleted the noop_meter branch September 19, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add noop metrics implementation
3 participants