Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noop metrics implementation #264

Closed
bg451 opened this issue Sep 16, 2019 · 0 comments · Fixed by #278
Closed

Add noop metrics implementation #264

bg451 opened this issue Sep 16, 2019 · 0 comments · Fixed by #278
Assignees
@bg451
Labels
feature-request
Milestone
Alpha v0.1

Comments

@bg451
Copy link
Member

bg451 commented Sep 16, 2019

With the metrics API in place, we need to add a noop implementation into the opentelemetry-core package. The implementation should have accompanying tests that ensure the noop implementation won't cause a crash, similar to the tracer's testing here
@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Sep 16, 2019
@mayurkale22 mayurkale22 added this to the API complete milestone Sep 16, 2019
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Sep 17, 2019
bg451 pushed a commit to bg451/opentelemetry-node that referenced this issue Sep 17, 2019
feat(metrics): adds NoopMeter implementation
ddd25d9 
Resolves open-telemetry#264
This was referenced Sep 17, 2019
Merged
Closed
bg451 added a commit that referenced this issue Sep 19, 2019
@bg451
feat(metrics): adds NoopMeter implementation (#278)
a9df567 
* feat(metrics): adds NoopMeter implementation

Resolves #264

* yarn fix

* rename test file

* fix the build attempt 1

* respond to comments

* fix the build part 2

* yarn fix
SuperButterfly pushed a commit to SuperButterfly/opentelemetry-js that referenced this issue Sep 18, 2022
@bg451
feat(metrics): adds NoopMeter implementation (#278)
01e9804 
* feat(metrics): adds NoopMeter implementation

Resolves open-telemetry/opentelemetry-js#264

* yarn fix

* rename test file

* fix the build attempt 1

* respond to comments

* fix the build part 2

* yarn fix
viridius-1 pushed a commit to viridius-1/opentelemetry-js that referenced this issue Jan 14, 2023
feat(metrics): adds NoopMeter implementation (#278)
b37513e 
* feat(metrics): adds NoopMeter implementation

Resolves open-telemetry/opentelemetry-js#264

* yarn fix

* rename test file

* fix the build attempt 1

* respond to comments

* fix the build part 2

* yarn fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bg451 bg451

Labels
feature-request
Projects
None yet
Milestone
Alpha v0.1
3 participants
@bg451 @danielkhan @mayurkale22