Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue regarding generated code #3

Closed
Rozengarden opened this issue Oct 25, 2023 · 0 comments
Closed

Issue regarding generated code #3

Rozengarden opened this issue Oct 25, 2023 · 0 comments
Labels
generator

Comments

@Rozengarden
Copy link
Contributor

I tested the generator for asset listing and encountered the following issues (config.json attached)

  • The generators print ENABLED or DISABLED instead of engineFlags.ENABLED
  • The generator outputs Rates.RateStrategyParams while the program in charge of outputting the import prefix expect IV3RateStrategyFactory.RateStrategyParams. ( feat: add new emode category via generator #2 fixes this in case of rates updates, but not in case of listing )
  • IERC20 doesn't get imported in the test file despite a test needing it

I also encountered the following unit conversion problems during compiling:

  • While I was defining the Emode for the listing compiler errored that AaveV3EthereumEModes.NONE was uint256 while EmodeCategory expected an uint8
  • in both the payload and the test, the compiler argued that AaveV3Ethereum.COLLECTOR was of type ICollector while the functions using it needed an address

Resources:
sakulstra added a commit that referenced this issue Oct 25, 2023
@sakulstra
fix: use correct contract an asset listings
008a61f 
- targets #3
brotherlymite added a commit that referenced this issue Oct 30, 2023
@brotherlymite @sakulstra
feat: add new emode category via generator (#2)
8cf2109 
* fix: typo

* chore: fix text

* feat: add new e-mode category via the generator

* fix: KEEP_CURRENT_STRING

* fix: emode label

* fix: generator booleanSelect ENABLED DISABLED

* fix: collateral updates code artifacts

* refactor: eModesUpdates

* fix: lint

* fix: generator shadows an existing priceFeedsUpdates var

* fix: v3 config engine rates import generator

* fix: v2 v3 engine rates import generator

* forge install: aave-address-book

v2.8.0

* chore: update address book

* fix: use correct contract an asset listings

- targets #3

* fix: some minor patches

* fix: remapping

* chore: some cleanup

* fix: do not revert when no e-mode category exists on the pool

* fix: makefile

* fix: eModesSelect

* fix: typo

* fix: asset listing approve before supply and collector funds

* fix: use forceApprove on generator for assetListing

* chore: update aave helpers

* fix: test

* fix: typo

---------

Co-authored-by: sakulstra <lukasstrassel@googlemail.com>
@sakulstra sakulstra mentioned this issue Nov 1, 2023
Open
brotherlymite added a commit that referenced this issue Nov 1, 2023
@brotherlymite @sakulstra @eboadom
feat: gnosis activation proposal (#8)
1450026 
* fix: typo

* chore: fix text

* feat: add new e-mode category via the generator

* fix: KEEP_CURRENT_STRING

* fix: emode label

* fix: generator booleanSelect ENABLED DISABLED

* fix: collateral updates code artifacts

* refactor: eModesUpdates

* fix: lint

* fix: generator shadows an existing priceFeedsUpdates var

* fix: v3 config engine rates import generator

* fix: v2 v3 engine rates import generator

* forge install: aave-address-book

v2.8.0

* chore: update address book

* fix: use correct contract an asset listings

- targets #3

* fix: some minor patches

* fix: remapping

* chore: some cleanup

* fix: do not revert when no e-mode category exists on the pool

* feat: initial gnosis listing payload

* chore: update aave-helpers lib

* fix: update payloads and add reports

* fix: tests

* fix: token amount

* feat: add sDAI

* feat: add aip text

* fix: lint

* fix: add more tests

* fix: add sDAI to aip text table

* fix: use forceApprove

* chore: update test block

* fix: ci

* refactor: supply

* fix: make guardian the pool admin

* chore: update aave helpers lib

* Update src/20231026_AaveV3Gnosis_AaveV3GnosisActivation/AaveV3GnosisActivation.md

Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>

* fix: update latest risk params

* fix: readme

* chore: check ci

* fix: ci

* fix: script

* fix: update aave helpers

* Update src/20231026_AaveV3Gnosis_AaveV3GnosisActivation/AaveV3GnosisActivation.md

Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>

* chore: add deploy address

---------

Co-authored-by: sakulstra <lukasstrassel@googlemail.com>
Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>
Rozengarden pushed a commit to Rozengarden/aave-proposals-v3 that referenced this issue Nov 2, 2023
@brotherlymite @sakulstra @Rozengarden
feat: add new emode category via generator (bgd-labs#2)
c431266 
* fix: typo

* chore: fix text

* feat: add new e-mode category via the generator

* fix: KEEP_CURRENT_STRING

* fix: emode label

* fix: generator booleanSelect ENABLED DISABLED

* fix: collateral updates code artifacts

* refactor: eModesUpdates

* fix: lint

* fix: generator shadows an existing priceFeedsUpdates var

* fix: v3 config engine rates import generator

* fix: v2 v3 engine rates import generator

* forge install: aave-address-book

v2.8.0

* chore: update address book

* fix: use correct contract an asset listings

- targets bgd-labs#3

* fix: some minor patches

* fix: remapping

* chore: some cleanup

* fix: do not revert when no e-mode category exists on the pool

* fix: makefile

* fix: eModesSelect

* fix: typo

* fix: asset listing approve before supply and collector funds

* fix: use forceApprove on generator for assetListing

* chore: update aave helpers

* fix: test

* fix: typo

---------

Co-authored-by: sakulstra <lukasstrassel@googlemail.com>
Rozengarden pushed a commit to Rozengarden/aave-proposals-v3 that referenced this issue Nov 2, 2023
@brotherlymite @sakulstra
@eboadom @Rozengarden
feat: gnosis activation proposal (bgd-labs#8)
a2cfc7d 
* fix: typo

* chore: fix text

* feat: add new e-mode category via the generator

* fix: KEEP_CURRENT_STRING

* fix: emode label

* fix: generator booleanSelect ENABLED DISABLED

* fix: collateral updates code artifacts

* refactor: eModesUpdates

* fix: lint

* fix: generator shadows an existing priceFeedsUpdates var

* fix: v3 config engine rates import generator

* fix: v2 v3 engine rates import generator

* forge install: aave-address-book

v2.8.0

* chore: update address book

* fix: use correct contract an asset listings

- targets bgd-labs#3

* fix: some minor patches

* fix: remapping

* chore: some cleanup

* fix: do not revert when no e-mode category exists on the pool

* feat: initial gnosis listing payload

* chore: update aave-helpers lib

* fix: update payloads and add reports

* fix: tests

* fix: token amount

* feat: add sDAI

* feat: add aip text

* fix: lint

* fix: add more tests

* fix: add sDAI to aip text table

* fix: use forceApprove

* chore: update test block

* fix: ci

* refactor: supply

* fix: make guardian the pool admin

* chore: update aave helpers lib

* Update src/20231026_AaveV3Gnosis_AaveV3GnosisActivation/AaveV3GnosisActivation.md

Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>

* fix: update latest risk params

* fix: readme

* chore: check ci

* fix: ci

* fix: script

* fix: update aave helpers

* Update src/20231026_AaveV3Gnosis_AaveV3GnosisActivation/AaveV3GnosisActivation.md

Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>

* chore: add deploy address

---------

Co-authored-by: sakulstra <lukasstrassel@googlemail.com>
Co-authored-by: Ernesto Boado <ebdmrr@gmail.com>
brotherlymite pushed a commit that referenced this issue Dec 7, 2023
@miguelmtzinf @parth-15
Add proposal for Gho Incident Report 20231113 (#109)
157a3fc 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
eboadom pushed a commit that referenced this issue Jan 20, 2024
@The-3D @parth-15
@miguelmtzinf @foodaka
StkGHO Initialization proposal (#170)
1982811 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: added stkgho initialization proposal

* feat: fixed proposal description

* feat: removed submodule

* feat: fixed deployment script

* feat: replaced duration calculation

* git commit remove submodule

* feat: fixed payload build function

* update proposal

* sync branch

* fix: variable name

* fix: Fix AIP payload

* fix: Fix tests

* test: added further test on emission per day

* refactor: removed unused constants

* fix: catapulta commands

* fix: Add fixes to payload

* fix: Rebuild proposal with autogenerate tool

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: Mark Hinschberger <foodaka@users.noreply.github.com>
eboadom pushed a commit that referenced this issue Jan 24, 2024
@miguelmtzinf @parth-15 @brotherlymite
GHO Stability Module Launch (#169)
0f4c6e7 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add payload

* test: Add tests

* feat: Add script and tests with final addresses

* fix: Fix link and gasLimit amounts

* fix: Update dependencies

* fix: Fix oracle swap freezer addresses

* fix: Bump block number for tests

* fix: Reduce LINK amount so its enough in treasury

* add test for OracleSwapFreezer

* fix: Clean up in tests

* docs: Add AIP text

* docs: Fix typo in natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo on natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* docs: Fix typo in natspec docs

* fix: Add DAO as swap freezer

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
Rozengarden referenced this issue in AaveChan/aave-proposals-v3 Jan 30, 2024
@The-3D @parth-15
@miguelmtzinf @foodaka @Rozengarden
StkGHO Initialization proposal (bgd-labs#170)
4502099 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (bgd-labs#9)

* fix: Remove unneeded diff file (bgd-labs#10)

* feat: added stkgho initialization proposal

* feat: fixed proposal description

* feat: removed submodule

* feat: fixed deployment script

* feat: replaced duration calculation

* git commit remove submodule

* feat: fixed payload build function

* update proposal

* sync branch

* fix: variable name

* fix: Fix AIP payload

* fix: Fix tests

* test: added further test on emission per day

* refactor: removed unused constants

* fix: catapulta commands

* fix: Add fixes to payload

* fix: Rebuild proposal with autogenerate tool

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: Mark Hinschberger <foodaka@users.noreply.github.com>
Rozengarden referenced this issue in AaveChan/aave-proposals-v3 Jan 30, 2024
@miguelmtzinf @parth-15
@brotherlymite @Rozengarden
GHO Stability Module Launch (bgd-labs#169)
6d5b5de 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (bgd-labs#9)

* fix: Remove unneeded diff file (bgd-labs#10)

* feat: Add payload

* test: Add tests

* feat: Add script and tests with final addresses

* fix: Fix link and gasLimit amounts

* fix: Update dependencies

* fix: Fix oracle swap freezer addresses

* fix: Bump block number for tests

* fix: Reduce LINK amount so its enough in treasury

* add test for OracleSwapFreezer

* fix: Clean up in tests

* docs: Add AIP text

* docs: Fix typo in natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo on natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* docs: Fix typo in natspec docs

* fix: Add DAO as swap freezer

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
brotherlymite pushed a commit that referenced this issue Jun 14, 2024
@miguelmtzinf @parth-15
Add AIP for GHO Cross-Chain Launch (#350)
7725647 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add AIP code

* fix: Fix AIP docs and imports

* fix: Remove unnecesary test

* fix: Updates risk params

* test: Add ccip e2e tests

* fix: Fix Arbitrum payload max bytecode size exceeded

* feat: Add sophisticated defensive aave seed (#13)

* feat: Add sophhisticated defensive aave seed

* fix: Allows AaveDefensive contract remove itself as facilitator

* fix: Add docs and reduce bytecode size

* fix: Reduce Utils lib bytecode size

* fix: Fix error in Utils

* fix: Add Capped gho usd price oracle

* fix: Add AIP draft text

* fix: Update block number for tests

* fix: Remove unneeded files

* fix: Install latest version of gho and ccip repos

* fix: Remove unused helper function

* fix: Fix AIP text

* fix: Remove defensive and use create2

* fix: Add fixed price oracle

* fix: Remove unnecessary memory variables

* fix: Use create1 and move listing out

* fix: Remove listing aip

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
brotherlymite pushed a commit that referenced this issue Jun 17, 2024
@miguelmtzinf @parth-15
Fix GHO cross-chain AIP text (#360)
e0d12ee 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* fix: Fix AIP text

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
brotherlymite added a commit that referenced this issue Jun 26, 2024
@miguelmtzinf @parth-15 @brotherlymite
Add second AIP for GHO Cross-Chain Launch (#356)
c7161d8 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add proposal to onboard GHO

* fix: Fix AIP name

* fix: Update GHO ir

* fix: Fix diff report

* fix: Fix typo in AIP text

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo in AIP text

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix tests

* fix: Fix lint

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
sendra added a commit that referenced this issue Jul 29, 2024
@CheyenneAtapour @parth-15
@miguelmtzinf @sendra
AIP: Events and Sponsorships Grant 2024 (#384)
ba24358 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* initial upload: proposal template and fund stream

* test: add stream withdraw test

* docs: add summary and specs of AIP

* test: add fuzz and insufficient funds tests

* test: fuzz by seconds instead of days

* fix: test changes as per pr comments

* fix: comment typo

* fix: discussion links, deal funds directly in tests

* feat: update proposal doc

* fix: doc header and formatting

* fix: replace arfc with aip

* fix: Fix typo in AIP text

Co-authored-by: sendra <sendra@users.noreply.github.com>

* feat: initial upload of template

* feat: initial upload doc

* fix: aip not arfc

* fix: Updates lib

* fix: Fix AIP text

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: sendra <sendra@users.noreply.github.com>
brotherlymite added a commit that referenced this issue Nov 7, 2024
@miguelmtzinf @parth-15
@DhairyaSethi @brotherlymite
GHO CCIP 1.5 Maintenance Upgrade (#512)
c016f11 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: install aave-ccip at latest commit on aave/ccip#18

* chore: upd remappings, lib/aave-helpers, .assets

* new: add proposal for eth & arb

* fix: arb test supply locked invariant

* fix: rename, add discussion link

* upd: aave-ccip module

* feat: add proxy pool deployments

* feat: add e2e tests

* chore: fix license, explicit senders for expectEmit

* ci: override rpc url in secrets

* test: proxy pool can off ramp

* chore: reorder deps

* nit: utilize existing ierc20 import, style guide, use arb assets for gho addy

* feat: add rate limit, use gho fascilitator for tests

* feat: set in bound rate limit as well

* chore: cleanup

* test: check proxy initialized version

* chore: inBetween => inFlight"

* chore: test name consistency

* test: dynamically fetch dest gas amt

* test: execMsg post migration using legacy off ramp

* test: ccip steward can disable rate limit

* chore: cleanup

* doc: add comment for fetching all offramps, use RISK_COUNCIL for clarity

* test: ownership transfer after migration

* chore: rm _readRiskAdmin, fix config

* fix: ci test setup to stay compatible with bdg upstream

* feat: rm aave-ccip dep

* rft: use deployed token pools

* tmp: fix ci for aave org, to rm for bdg

* fix: ci to bdg setup

* fix: update rate limit

* test: fuzz amounts

* chore: snapshot docs

* chore: const cap rate

* chore: fix type

* fix: Fix rate limit config constants

* fix: tests, impl correct solc

* fix: tests

* Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Ethereum_GHOCCIP150Upgrade_20241021.sol

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021.sol

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* doc: reference token pool contracts

* doc: upgrade spec

* doc: formatting

* Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md

Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>

* Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md

Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>

* test: Refresh block number with ghostewards aip executed

* fix: Remove unneeded script

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: DhairyaSethi <55102840+DhairyaSethi@users.noreply.github.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
generator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sakulstra @Rozengarden