Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI Phase II #9

Merged
merged 8 commits into from
Oct 31, 2023
Merged

ACI Phase II #9

merged 8 commits into from
Oct 31, 2023

Conversation

JosepBove
Copy link
Contributor

@JosepBove @Zer0dot
Change typo on authors
0643fe2 
Co-authored-by: Zer0dot <zer0dot.dev@gmail.com>
@JosepBove
Copy link
Contributor Author

Comments applied!

@sendra
Copy link
Contributor

sendra commented Oct 31, 2023

A pull from main, and forge install is needed, as aave-helpers was updated

@github-actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Foundry report

forge 0.2.0 (94ae897 2023-10-31T00:16:51.730405056Z)
Build log 
installing solc version "0.8.22"
Successfully installed solc 0.8.22
Compiling 101 files with 0.8.22
Solc 0.8.22 finished in 15.56s
Compiler run successful with warnings:
Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
   --> lib/aave-helpers/src/GovV3Helpers.sol:732:5:
    |
732 |     address votingPortal
    |     ^^^^^^^^^^^^^^^^^^^^

| Contract                           | Size (kB) | Margin (kB) |
|------------------------------------|-----------|-------------|
| AaveGovernanceV2                   | 0.086     | 24.49       |
| AaveV2Avalanche                    | 0.086     | 24.49       |
| AaveV2AvalancheAssets              | 0.086     | 24.49       |
| AaveV2Ethereum                     | 0.086     | 24.49       |
| AaveV2EthereumAMM                  | 0.086     | 24.49       |
| AaveV2EthereumAMMAssets            | 0.086     | 24.49       |
| AaveV2EthereumAssets               | 0.086     | 24.49       |
| AaveV2Polygon                      | 0.086     | 24.49       |
| AaveV2PolygonAssets                | 0.086     | 24.49       |
| AaveV3Arbitrum                     | 0.086     | 24.49       |
| AaveV3ArbitrumAssets               | 0.086     | 24.49       |
| AaveV3ArbitrumEModes               | 0.086     | 24.49       |
| AaveV3Avalanche                    | 0.086     | 24.49       |
| AaveV3AvalancheAssets              | 0.086     | 24.49       |
| AaveV3AvalancheEModes              | 0.086     | 24.49       |
| AaveV3Ethereum                     | 0.086     | 24.49       |
| AaveV3EthereumAssets               | 0.086     | 24.49       |
| AaveV3EthereumEModes               | 0.086     | 24.49       |
| AaveV3Ethereum_ACIPhaseII_20231029 | 0.682     | 23.894      |
| AaveV3Fantom                       | 0.086     | 24.49       |
| AaveV3FantomAssets                 | 0.086     | 24.49       |
| AaveV3FantomEModes                 | 0.086     | 24.49       |
| AaveV3Harmony                      | 0.086     | 24.49       |
| AaveV3HarmonyAssets                | 0.086     | 24.49       |
| AaveV3HarmonyEModes                | 0.086     | 24.49       |
| AaveV3Optimism                     | 0.086     | 24.49       |
| AaveV3OptimismAssets               | 0.086     | 24.49       |
| AaveV3OptimismEModes               | 0.086     | 24.49       |
| AaveV3Polygon                      | 0.086     | 24.49       |
| AaveV3PolygonAssets                | 0.086     | 24.49       |
| AaveV3PolygonEModes                | 0.086     | 24.49       |
| Address                            | 0.086     | 24.49       |
| ChainHelpers                       | 0.086     | 24.49       |
| ChainIds                           | 0.086     | 24.49       |
| ConfiguratorInputTypes             | 0.086     | 24.49       |
| Create2Utils                       | 0.164     | 24.412      |
| DataTypes                          | 0.086     | 24.49       |
| Errors                             | 4.715     | 19.861      |
| GovHelpers                         | 0.086     | 24.49       |
| GovV3Helpers                       | 0.086     | 24.49       |
| GovV3StorageHelpers                | 0.086     | 24.49       |
| GovernanceV3Arbitrum               | 0.086     | 24.49       |
| GovernanceV3Avalanche              | 0.086     | 24.49       |
| GovernanceV3BNB                    | 0.086     | 24.49       |
| GovernanceV3Base                   | 0.086     | 24.49       |
| GovernanceV3Ethereum               | 0.086     | 24.49       |
| GovernanceV3Gnosis                 | 0.086     | 24.49       |
| GovernanceV3Metis                  | 0.086     | 24.49       |
| GovernanceV3Optimism               | 0.086     | 24.49       |
| GovernanceV3Polygon                | 0.086     | 24.49       |
| IpfsUtils                          | 0.086     | 24.49       |
| MiscEthereum                       | 0.086     | 24.49       |
| MockExecutor                       | 0.437     | 24.139      |
| PayloadsControllerUtils            | 0.086     | 24.49       |
| ProxyHelpers                       | 0.086     | 24.49       |
| ReserveConfiguration               | 0.171     | 24.405      |
| SafeERC20                          | 0.086     | 24.49       |
| StdStyle                           | 0.086     | 24.49       |
| StorageHelpers                     | 0.086     | 24.49       |
| console                            | 0.086     | 24.49       |
| console2                           | 0.086     | 24.49       |
| safeconsole                        | 0.086     | 24.49       |
| stdError                           | 0.592     | 23.984      |
| stdJson                            | 0.086     | 24.49       |
| stdMath                            | 0.086     | 24.49       |
| stdStorage                         | 0.086     | 24.49       |
| stdStorageSafe                     | 0.086     | 24.49       |
Test success 🌈 
No files changed, compilation skipped

Running 1 test for src/20231029_AaveV3Ethereum_ACIPhaseII/AaveV3Ethereum_ACIPhaseII_20231029.t.sol:AaveV3Ethereum_ACIPhaseII_20231029_Test
[PASS] testProposalExecution() (gas: 250177)
Test result: ok. 1 passed; 0 failed; 0 skipped; finished in 2.01s
 
Ran 1 test suites: 1 tests passed, 0 failed, 0 skipped (1 total tests)

Zer0dot
Zer0dot reviewed Oct 31, 2023
View reviewed changes
src/20231029_AaveV3Ethereum_ACIPhaseII/AaveV3Ethereum_ACIPhaseII_20231029.t.sol
// checking if the ACI can withdraw from the stream

vm.startPrank(ACI_TREASURY);
vm.warp(block.timestamp + STREAM_DURATION + 1 days);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, I'd recommend testing withdrawing prior to the end of the stream for completeness. No need to affect this now, as the streams are out of scope here, and the test does ensure it's created.

Just something to keep in mind for future stream proposals.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted for future proposals.

@Zer0dot Zer0dot merged commit afd6010 into bgd-labs:main Oct 31, 2023
2 checks passed
Rozengarden added a commit to Rozengarden/aave-proposals-v3 that referenced this pull request Nov 2, 2023
@JosepBove @Rozengarden @Zer0dot
ACI Phase II (bgd-labs#9)
4e94f6f 
* generator output + filling in .md

* code paylaod

* lil changes to the .md

* add test

* Change typo on authors

Co-authored-by: Zer0dot <zer0dot.dev@gmail.com>

* init

* payload deployed

---------

Co-authored-by: Rozengarden <github@rozengarden.eu>
Co-authored-by: Zer0dot <zer0dot.dev@gmail.com>
Co-authored-by: Marc Zeller <pierarte@gmail.com>
brotherlymite pushed a commit that referenced this pull request Dec 7, 2023
@miguelmtzinf @parth-15
Add proposal for Gho Incident Report 20231113 (#109)
157a3fc 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
eboadom pushed a commit that referenced this pull request Jan 20, 2024
@The-3D @parth-15
@miguelmtzinf @foodaka
StkGHO Initialization proposal (#170)
1982811 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: added stkgho initialization proposal

* feat: fixed proposal description

* feat: removed submodule

* feat: fixed deployment script

* feat: replaced duration calculation

* git commit remove submodule

* feat: fixed payload build function

* update proposal

* sync branch

* fix: variable name

* fix: Fix AIP payload

* fix: Fix tests

* test: added further test on emission per day

* refactor: removed unused constants

* fix: catapulta commands

* fix: Add fixes to payload

* fix: Rebuild proposal with autogenerate tool

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: Mark Hinschberger <foodaka@users.noreply.github.com>
eboadom pushed a commit that referenced this pull request Jan 24, 2024
@miguelmtzinf @parth-15 @brotherlymite
GHO Stability Module Launch (#169)
0f4c6e7 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add payload

* test: Add tests

* feat: Add script and tests with final addresses

* fix: Fix link and gasLimit amounts

* fix: Update dependencies

* fix: Fix oracle swap freezer addresses

* fix: Bump block number for tests

* fix: Reduce LINK amount so its enough in treasury

* add test for OracleSwapFreezer

* fix: Clean up in tests

* docs: Add AIP text

* docs: Fix typo in natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo on natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* docs: Fix typo in natspec docs

* fix: Add DAO as swap freezer

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
Rozengarden pushed a commit to AaveChan/aave-proposals-v3 that referenced this pull request Jan 30, 2024
@The-3D @parth-15
@miguelmtzinf @foodaka @Rozengarden
StkGHO Initialization proposal (bgd-labs#170)
4502099 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (bgd-labs#9)

* fix: Remove unneeded diff file (bgd-labs#10)

* feat: added stkgho initialization proposal

* feat: fixed proposal description

* feat: removed submodule

* feat: fixed deployment script

* feat: replaced duration calculation

* git commit remove submodule

* feat: fixed payload build function

* update proposal

* sync branch

* fix: variable name

* fix: Fix AIP payload

* fix: Fix tests

* test: added further test on emission per day

* refactor: removed unused constants

* fix: catapulta commands

* fix: Add fixes to payload

* fix: Rebuild proposal with autogenerate tool

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: Mark Hinschberger <foodaka@users.noreply.github.com>
Rozengarden pushed a commit to AaveChan/aave-proposals-v3 that referenced this pull request Jan 30, 2024
@miguelmtzinf @parth-15
@brotherlymite @Rozengarden
GHO Stability Module Launch (bgd-labs#169)
6d5b5de 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (bgd-labs#9)

* fix: Remove unneeded diff file (bgd-labs#10)

* feat: Add payload

* test: Add tests

* feat: Add script and tests with final addresses

* fix: Fix link and gasLimit amounts

* fix: Update dependencies

* fix: Fix oracle swap freezer addresses

* fix: Bump block number for tests

* fix: Reduce LINK amount so its enough in treasury

* add test for OracleSwapFreezer

* fix: Clean up in tests

* docs: Add AIP text

* docs: Fix typo in natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo on natspec docs

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* docs: Fix typo in natspec docs

* fix: Add DAO as swap freezer

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
brotherlymite pushed a commit that referenced this pull request Jun 14, 2024
@miguelmtzinf @parth-15
Add AIP for GHO Cross-Chain Launch (#350)
7725647 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add AIP code

* fix: Fix AIP docs and imports

* fix: Remove unnecesary test

* fix: Updates risk params

* test: Add ccip e2e tests

* fix: Fix Arbitrum payload max bytecode size exceeded

* feat: Add sophisticated defensive aave seed (#13)

* feat: Add sophhisticated defensive aave seed

* fix: Allows AaveDefensive contract remove itself as facilitator

* fix: Add docs and reduce bytecode size

* fix: Reduce Utils lib bytecode size

* fix: Fix error in Utils

* fix: Add Capped gho usd price oracle

* fix: Add AIP draft text

* fix: Update block number for tests

* fix: Remove unneeded files

* fix: Install latest version of gho and ccip repos

* fix: Remove unused helper function

* fix: Fix AIP text

* fix: Remove defensive and use create2

* fix: Add fixed price oracle

* fix: Remove unnecessary memory variables

* fix: Use create1 and move listing out

* fix: Remove listing aip

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
brotherlymite pushed a commit that referenced this pull request Jun 17, 2024
@miguelmtzinf @parth-15
Fix GHO cross-chain AIP text (#360)
e0d12ee 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* fix: Fix AIP text

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
brotherlymite added a commit that referenced this pull request Jun 26, 2024
@miguelmtzinf @parth-15 @brotherlymite
Add second AIP for GHO Cross-Chain Launch (#356)
c7161d8 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add proposal to onboard GHO

* fix: Fix AIP name

* fix: Update GHO ir

* fix: Fix diff report

* fix: Fix typo in AIP text

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix typo in AIP text

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* fix: Fix tests

* fix: Fix lint

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
sendra added a commit that referenced this pull request Jul 29, 2024
@CheyenneAtapour @parth-15
@miguelmtzinf @sendra
AIP: Events and Sponsorships Grant 2024 (#384)
ba24358 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* initial upload: proposal template and fund stream

* test: add stream withdraw test

* docs: add summary and specs of AIP

* test: add fuzz and insufficient funds tests

* test: fuzz by seconds instead of days

* fix: test changes as per pr comments

* fix: comment typo

* fix: discussion links, deal funds directly in tests

* feat: update proposal doc

* fix: doc header and formatting

* fix: replace arfc with aip

* fix: Fix typo in AIP text

Co-authored-by: sendra <sendra@users.noreply.github.com>

* feat: initial upload of template

* feat: initial upload doc

* fix: aip not arfc

* fix: Updates lib

* fix: Fix AIP text

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>
Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>
Co-authored-by: sendra <sendra@users.noreply.github.com>
brotherlymite added a commit that referenced this pull request Nov 7, 2024
@miguelmtzinf @parth-15
@DhairyaSethi @brotherlymite
GHO CCIP 1.5 Maintenance Upgrade (#512)
c016f11 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: install aave-ccip at latest commit on aave/ccip#18

* chore: upd remappings, lib/aave-helpers, .assets

* new: add proposal for eth & arb

* fix: arb test supply locked invariant

* fix: rename, add discussion link

* upd: aave-ccip module

* feat: add proxy pool deployments

* feat: add e2e tests

* chore: fix license, explicit senders for expectEmit

* ci: override rpc url in secrets

* test: proxy pool can off ramp

* chore: reorder deps

* nit: utilize existing ierc20 import, style guide, use arb assets for gho addy

* feat: add rate limit, use gho fascilitator for tests

* feat: set in bound rate limit as well

* chore: cleanup

* test: check proxy initialized version

* chore: inBetween => inFlight"

* chore: test name consistency

* test: dynamically fetch dest gas amt

* test: execMsg post migration using legacy off ramp

* test: ccip steward can disable rate limit

* chore: cleanup

* doc: add comment for fetching all offramps, use RISK_COUNCIL for clarity

* test: ownership transfer after migration

* chore: rm _readRiskAdmin, fix config

* fix: ci test setup to stay compatible with bdg upstream

* feat: rm aave-ccip dep

* rft: use deployed token pools

* tmp: fix ci for aave org, to rm for bdg

* fix: ci to bdg setup

* fix: update rate limit

* test: fuzz amounts

* chore: snapshot docs

* chore: const cap rate

* chore: fix type

* fix: Fix rate limit config constants

* fix: tests, impl correct solc

* fix: tests

* Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Ethereum_GHOCCIP150Upgrade_20241021.sol

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021.sol

Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>

* doc: reference token pool contracts

* doc: upgrade spec

* doc: formatting

* Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md

Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>

* Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md

Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com>

* test: Refresh block number with ghostewards aip executed

* fix: Remove unneeded script

---------

Co-authored-by: Parth Patel <parth4321patel@gmail.com>
Co-authored-by: DhairyaSethi <55102840+DhairyaSethi@users.noreply.github.com>
Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marczeller marczeller marczeller left review comments

@rustboyar rustboyar rustboyar approved these changes

@Zer0dot Zer0dot Zer0dot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JosepBove @sendra @Zer0dot @rustboyar @marczeller @Rozengarden