Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeof process!='undefined' rather than process != undefined #1

Closed
wants to merge 1 commit into from

Conversation

rvagg
Copy link

@rvagg rvagg commented Apr 27, 2013

No description provided.

@bhouston
Copy link
Owner

This actually doesn't get through the google closure compiler. I've submitted a different style of fix here:

mrdoob#3399

Can you try it out and see if it works in your use case?

@bhouston
Copy link
Owner

Closing because it is addressed in a PR to mrdoob's threejs project itself.

@bhouston bhouston closed this Apr 29, 2013
@rvagg
Copy link
Author

rvagg commented Apr 29, 2013

The problem still appears because I'm using this as part of an Ender build so it's in a browser environment but without process (unlike browserify I guess). So it's still borking on process !== undefined. Could you switch it to global.process !== undefined?

@bhouston
Copy link
Owner

So I got rid of accessing process directly as well in this fix:

http://github.com/mrdoob/three.js/pull/3403/files

@rvagg
Copy link
Author

rvagg commented Apr 29, 2013

Ah, ok, will wait for the npm version. Cheers!

@rvagg rvagg deleted the patch-1 branch April 29, 2013 23:54
@bhouston
Copy link
Owner

this is already published as the three npm module. please try it. I think it should just work.

@bhouston
Copy link
Owner

The version you want is 0.58.7 here https://npmjs.org/package/three :-)

@rvagg
Copy link
Author

rvagg commented Apr 29, 2013

[rvagg@rocky /tmp]$ npm install three
npm http GET https://registry.npmjs.org/three
npm http 304 https://registry.npmjs.org/three
three@0.58.7 node_modules/three
[rvagg@rocky /tmp]$ grep process node_modules/three/three.js 
    if( ( process !== undefined ) && ( process.hrtime !== undefined ) ) {
...

@bhouston
Copy link
Owner

Sorry about that. Try 0.58.8. I checked and I found no use of the global process in it.

bhouston pushed a commit that referenced this pull request Jul 24, 2014
bhouston pushed a commit that referenced this pull request Feb 19, 2015
bhouston added a commit that referenced this pull request Mar 9, 2015
bhouston pushed a commit that referenced this pull request Mar 10, 2015
bhouston pushed a commit that referenced this pull request Mar 18, 2015
bhouston pushed a commit that referenced this pull request Jun 9, 2015
bhouston pushed a commit that referenced this pull request Jul 22, 2015
updated origin with main stream
bhouston pushed a commit that referenced this pull request Jul 22, 2015
.clone() and .toJSON() added to AreaLight
bhouston pushed a commit that referenced this pull request Nov 2, 2015
Getting up to date with upstream
bhouston pushed a commit that referenced this pull request Feb 18, 2016
Modify smoothing pattern to support multiple digits
bhouston pushed a commit that referenced this pull request Apr 1, 2016
Jozain pushed a commit that referenced this pull request Dec 23, 2016
mrdoob pushed a commit that referenced this pull request Jan 22, 2017
bhouston pushed a commit that referenced this pull request Feb 24, 2017
Pulling updates from three.js
bhouston pushed a commit that referenced this pull request Mar 15, 2017
Create webgl_geometry_text_shapes.html
bhouston pushed a commit that referenced this pull request Apr 6, 2017
clarified type of first param to constructor
bhouston pushed a commit that referenced this pull request Apr 6, 2017
bhouston added a commit that referenced this pull request Jul 12, 2017
bhouston pushed a commit that referenced this pull request Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants