-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typeof process!='undefined' rather than process != undefined #1
Conversation
This actually doesn't get through the google closure compiler. I've submitted a different style of fix here: Can you try it out and see if it works in your use case? |
Closing because it is addressed in a PR to mrdoob's threejs project itself. |
The problem still appears because I'm using this as part of an Ender build so it's in a browser environment but without |
So I got rid of accessing process directly as well in this fix: http://github.com/mrdoob/three.js/pull/3403/files |
Ah, ok, will wait for the npm version. Cheers! |
this is already published as the three npm module. please try it. I think it should just work. |
The version you want is 0.58.7 here https://npmjs.org/package/three :-) |
[rvagg@rocky /tmp]$ npm install three
npm http GET https://registry.npmjs.org/three
npm http 304 https://registry.npmjs.org/three
three@0.58.7 node_modules/three
[rvagg@rocky /tmp]$ grep process node_modules/three/three.js
if( ( process !== undefined ) && ( process.hrtime !== undefined ) ) {
... |
Sorry about that. Try 0.58.8. I checked and I found no use of the global process in it. |
updated origin with main stream
.clone() and .toJSON() added to AreaLight
Getting up to date with upstream
Modify smoothing pattern to support multiple digits
Pulling updates from three.js
Create webgl_geometry_text_shapes.html
clarified type of first param to constructor
No description provided.