Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEG - confusion between channels.tsv and electrodes.tsv #667

Closed
arnodelorme opened this issue Nov 11, 2020 · 4 comments · Fixed by #734
Closed

EEG - confusion between channels.tsv and electrodes.tsv #667

arnodelorme opened this issue Nov 11, 2020 · 4 comments · Fixed by #734
Labels
EEG Electroencephalography iEEG

Comments

@arnodelorme
Copy link

This dataset for example (https://openneuro.org/datasets/ds002791/versions/1.0.0) has different channel names in its channels.tsv and electrodes.tsv files.

sub-01/ses-naming/eeg/sub-01_ses-naming_run-1_electrodes.tsv
F10h 6.962 5.382 -2.191
F8 6.484 6.404 -0.14
AFF8h 5.699 7.208 1.791

sub-01/ses-naming/eeg/sub-01_ses-naming_run-1_channels.tsv
E1 eeg microV 1000 n/a n/a n/a n/a n/a n/a n/a
E2 eeg microV 1000 n/a n/a n/a n/a n/a n/a n/a
E3 eeg microV 1000 n/a n/a n/a n/a n/a n/a n/a
...

The specification suggests that the name should be the same. It also does not enforce that electrodes.tsv should have the same number of rows as channels.tsv.

https://bids-specification.readthedocs.io/en/latest/04-modality-specific-files/03-electroencephalography.html

Solutions:

  1. Clarity in the specification that electrodes.tsv should have the same number of rows as channels.tsv
  2. Change the validator to enforce that channel names are the same between electrodes.tsv and channels.tsv
@sappelhoff
Copy link
Member

electrodes.tsv could have more electrodes than present in channels.tsv for example in the case where an EOG channel (1 channel) is recorded from 2 electrodes with bipolar referencing scheme.

@sappelhoff
Copy link
Member

The specification suggests that the name should be the same. It also does not enforce that electrodes.tsv should have the same number of rows as channels.tsv.

actually, could you please cite where you get that idea from? I read the parts of the spec again, and I cannot find that rule.

It also wouldn't make sense in my opinion, apart from the example about bipolar electrodes I listed above. --> Just thinking about a "normal" EEG recording with a reference and a ground electrode --> neither of these two electrodes are "channels" ... but they should be written down in electrodes.tsv.

Unless more information comes up, I would say that we should rather enhance the specification with one or two examles of why the names column in channels.tsv and electrodes.tsv do NOT have to be exactly the same (in fact, they cannot be the same sometimes)

We hint at that in the intro:

Note that for proper documentation of EEG recording metadata it is important to understand the difference between electrode and channel: An EEG electrode is attached to the skin, whereas a channel is the combination of the analog differential amplifier and analog-to-digital converter that result in a potential (voltage) difference that is stored in the EEG dataset. We employ the following short definitions:

  • Electrode = A single point of contact between the acquisition system and the recording site (for example, scalp, neural tissue, ...). Multiple electrodes can be organized as caps (for EEG), arrays, grids, leads, strips, probes, shafts, and so on.
  • Channel = A single analog-to-digital converter in the recording system that regularly samples the value of a transducer, which results in the signal being represented as a time series in the digitized data. This can be connected to two electrodes (to measure the potential difference between them), a magnetic field or magnetic gradient sensor, temperature sensor, accelerometer, and so on.

@sappelhoff sappelhoff added EEG Electroencephalography iEEG labels Feb 10, 2021
sappelhoff added a commit to sappelhoff/bids-specification that referenced this issue Feb 13, 2021
sappelhoff added a commit to sappelhoff/bids-specification that referenced this issue Feb 24, 2021
sappelhoff added a commit to sappelhoff/bids-specification that referenced this issue Mar 1, 2021
sappelhoff added a commit that referenced this issue Mar 5, 2021
…nels+electrodes do not have to match (#734)

* clarify that label of _space-<label> must be from appendix VIII

related to https://github.com/bids-standard/bids-validator/issues/743

* clarify that channels and electrodes do not have to match

closes #667

* catch typo again

* link channels+electrodes examples

* clarify _where_ restricted keywords for space entity come from

* fix typo L -> l (capitalization)

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

* extend yml lint limit to 120 chard

* use existing .yamllint.yml file

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@CPernet
Copy link
Collaborator

CPernet commented Mar 28, 2021

we could suggest to use the the same names for electrodes and channels

@dorahermes
Copy link
Member

On the topic of adding some examples where it is more difficult to match the positions (in addition to bipolar recordings):

Example 1: a dataset in which an ECG channel is recorded simultaneously with SEEG. The ECG electrode is not present or is n/a in _electrodes.tsv

Example 2: EEG and SEEG are simultaneously recorded and the EEG positions may not be present or are in a different space than the SEEG positions.

However, if a name in _channels.tsv is not present in _electrodes.tsv that maybe should raise a flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EEG Electroencephalography iEEG
Projects
None yet
4 participants