-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] 1) Clarify appropriate labels for space entity, 2) Clarify channels+electrodes do not have to match #734
Conversation
One question I have is that if space must be taken from a list of the accepted keywords and might be tied to an anatomical image via the Say I have iEEG data in
Related https://github.com/bids-standard/bids-validator/issues/1059#event-4325876812 |
This is a good question that I stumbled over as well. I don't know how this was envisioned when the
so you have the same scan twice, but just in two different coordinate systems?
It is indeed inconvenient that Otherwise it'd be simply
and for your
NOTES
Ideas
|
Yes, I think this is common and possible. It is for me at least. My workflow would entail i) receiving dicoms from clinicians and converting to nifti, (original "scanner" space if you will) ii) do some preprocessing ( Now, rises our problem :/.
To my reading of the BIDS spec, it is not included. It is mentioned in the
+1 if not in there.
+1 unless there is an alternative fix for this kind of thing. Then perhaps, it'd be useful to add to the spec for BIDS-iEEG?
Yes agreed. I would be surprised if I ever needed two |
Questions:
|
I suppose yes then... I suppose then the FreeSurfer "derived" files of an individual subject T1w scan is considered a derivative. But to be fair, if I instead use the FreeSurfer MNI template (i.e. fsaverage), then technically, it's still a derivative image that you use to localize the ieeg electrodes.
Yep, not sure what the right answer here is...
I basically "hack" acquisition entity since "space" is not allowed, or I add space, but I use |
Current SummaryI think the issues are the following:
Old solutionFor coordsystem.sjon/electrodes.tsv use For the actual Proposed solutions
|
@adam2392 given that your https://github.com/bids-standard/bids-validator/pull/1190 was merged and the validator now properly enforces that the label for Your issue is still not resolved, but I think it may be good if you could write brief a summary and open a new issue, and then tag all people who have to say something about this in order to move forward. The alternative is that you keep hacking |
@hoechenberger see also this discussion |
I typically consider transformations to be derivatives, like in fMRI. For my studies, my raw data have only one _electrodes.tsv file in T1w space with the T1 scan indicated in the IntendedFor field (and maybe an MNI space one). When I convert the electrode coordinates to several other T1w spaces (acpc alligned/fsnative etc), I consider this derived data (similar as fMRI coregistration/reslicing is a derivative). |
Thanks for clarifying @dorahermes ! So for the sake of analyzing iEEG data, for most of our purposes, there is no reason to have electrode coordinates in the original scanner space, because we can't do much w/ it. Overlaying it in the
To allow fully traceable interpretation of the electrode coordinates that is BIDS-compliant? Am I missing anything? I'm just having a hard time fitting our lab's workflow into BIDS in this current context and I can't decipher how to best proceed based on the spec :/ |
src/04-modality-specific-files/04-intracranial-electroencephalography.md
Outdated
Show resolved
Hide resolved
this is sensitive to capitalization, so it'd have to be
note that in that case, your
I don't really know what this does. @effigies can you help us? |
{
"SpatialReference": "/sub-01/anat/sub-01_T1w.nii.gz"
} (Or similar. I didn't check if I did that properly...) Is that helpful, or am I misunderstanding the question? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I think there's a typo though.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Okay, this only leaves us to resolve @adam2392's problem. Let me try to summarize:
@effigies, your answer #734 (comment) does currently not help me to understand this 🤔 Apart from that, it'd be more convenient for @adam2392 to actually store the rotated MRIs not in derivatives, but in raw ... and for that we'd need to:
@adam2392 please chime in if I misrepresented one of your points. |
notes from maintainers meeting:
|
I'll interpret Chris' review from #734 (review) as an approval, merging. @adam2392 if you wanna solve your issue in some way, please open a targeted issue 👍 |
minor clarifications concerning iEEG, MEG, EEG:
_space-<label>
entity MUST come from a restricted list of keywordsNOTE: Also contains a large discussion on the
space
entity, and its lack of support in "raw BIDS" MRI data (supported only for "derivatives" MRI data currently), and more ...