-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
space
filename keyword is not restricted to the controlled vocabulary
#743
Comments
Yes, this is my understanding also. The reason for this question is that many iEEG coordinates are in the original scanner space of the T1 and there is no specific tag for this yet, and adding this tag (e.g. -orig) from the iEEG spec was not preferred. |
There's discussion over in bids-standard/bids-specification#109 (currently at the bottom) about the subject-native T1w "space", and how that should be treated. Input from interested parties would be welcome. |
We made some progress, see: https://bids-specification.readthedocs.io/en/latest/99-appendices/08-coordinate-systems.html in brief:
This is now finally also validated in the JSON schemas. However it remains an open issue with the filenames: it's currently possible for someone to have a file like Filenames should be checked such that their As a first step however, it would probably already be an improvement to constrain the RegExps for cc @adam2392 |
From this list, I don't see |
@adam2392 the list you should look at is in appendix VIII you could also look at the JSON schema for these fields. That is used to validate the |
Currently discussing with @sappelhoff about some issue with the The topic is usage of |
…nels+electrodes do not have to match (#734) * clarify that label of _space-<label> must be from appendix VIII related to https://github.com/bids-standard/bids-validator/issues/743 * clarify that channels and electrodes do not have to match closes #667 * catch typo again * link channels+electrodes examples * clarify _where_ restricted keywords for space entity come from * fix typo L -> l (capitalization) Co-authored-by: Chris Markiewicz <effigies@gmail.com> * extend yml lint limit to 120 chard * use existing .yamllint.yml file Co-authored-by: Chris Markiewicz <effigies@gmail.com>
See https://github.com/bids-standard/bids-validator/blob/2dab5a40bf38292bf91a1bedeb4dfddfe0d06b05/bids-validator/bids_validator/rules/file_level_rules.json#L174
My reading of the spec is that the allowed values are:
Related to https://neurostars.org/t/questions-about-appendix-viii-preferred-names-of-coordinate-systems/3758. Pinging @dorahermes and @choldgraf for confirmation
The text was updated successfully, but these errors were encountered: