Refactor testing and arbitrary extension handling #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ypriverol LMK what you think |
ypriverol
reviewed
Sep 17, 2023
|
@ypriverol as we talked about, I added the extended handling of extensions |
ypriverol
approved these changes
Sep 17, 2023
| @@ -37,6 +36,17 @@ def get_openms_file_name(raw, extension_convert: str = None): | |||
| :param extension_convert: convert extension to specified format | |||
| :return: converted file name | |||
| """ | |||
|
|
|||
| def _removesuffix(x: str, suffix: str, /) -> str: | |||
There was a problem hiding this comment.
Beautiful implementation @jspaezp
jspaezp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to increase the test cases in the repo and make it easier to maintain.
In addition,
EDIT:
.gz -> .dor.d.zip -> .d, while at the same time handling graciously cases where the passed conversions are not used (ie,raw:mzmldoes not error out if there are both.rawand.mzmlfiles)