-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SAML authentication #1334
Add SAML authentication #1334
Conversation
Thanks alot, we will most likely patch this into out setup. |
Hello, we tested this with LemonLDAP::NG as SAML IDP and it works well. It would be great to include this in the official BBB code. |
I'm very interested in seeing this feature land in Greenlight. One minor hurdle I encountered is while opening the user profile after a successful login, I get a 500 error, possibly due to language options being uninitialized
Thanks a lot for sharing your branch |
Hi, |
It won't be merged since they don't want to support it. We merged this and run it in production |
This is a open source project and there were multiple attempts to add SAML2 / OpenID Connect authentications support. Instead of adding SAML2 / OIDC, which are industry standards for doing a Single Sign On, greenlight supports Google? Twitter? Office365? authenticaton support? SAML2 / OIDC is supportd by many different Single Sign On components like Keycloak and its downstream product Redhat SSO. A lot of awesome tools are supporting it, too. It would be gerat to add OIDC or SAML. |
We are running this in production with good results. Can you please consider to merge it? It's not very invasive and as argued above because it uses open standards it can be beneficial to many different use cases. |
We patched this into our production setup a few months ago and it works fine for us. |
+1 :) |
Now that we've merged support for OpenID Connect, there are no plans to support SAML directly. We suggest using OIDC providers and using SAML through the provider |
Don't work with the latest version of Greenlight. Gems need to be updated. |
@sparse91 what do you meant? The custom saml patches or the openID integration? |
@ichdasich This SAML patch. |
You have to keep REXML at 3.2.4 (note: 3.2.5 was a security update! Assess whether it applies to your infra!) and then rebuild GL with that. See: omniauth/omniauth-saml#199 I would recommend figuring out how to migrate to the buildin openid connector, though. ;-) |
This is a basic reimplementation of #185 on current master. (related FR: #1253)
Now I know that it is not going to be merged probably, but I wanted to make this available to other interested parties so it can at least be pulled into individual installations.