Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby-saml (~> 1.9) breaks authentication due to adjusted behavior in REXML (3.2.5) #199

Closed
ichdasich opened this issue May 9, 2021 · 0 comments · Fixed by #200
Closed

ruby-saml (~> 1.9) breaks authentication due to adjusted behavior in REXML (3.2.5) #199

ichdasich opened this issue May 9, 2021 · 0 comments · Fixed by #200

Comments

@ichdasich
Copy link

ichdasich commented May 9, 2021 •
edited
Loading

In 3.2.5 REXML performed some security patches, which now trigger a bug in ruby-saml before 1.12.1, see: SAML-Toolkits/ruby-saml#577

This essentially prevents saml authentication with omniauth-saml as ruby-saml is ~> 1.9 even in 2.0.0.
bufferoverflow added a commit that referenced this issue May 9, 2021
@bufferoverflow
chore: bump ruby-saml to 1.12
15c156a 
Closes #199
@bufferoverflow bufferoverflow mentioned this issue May 9, 2021
Merged
@ichdasich ichdasich mentioned this issue May 9, 2021
Closed
JannikStreek pushed a commit to nwittstruck/omniauth-saml that referenced this issue Jul 9, 2021
@bufferoverflow @JannikStreek
chore: bump ruby-saml to 1.12
02f3892 
Closes omniauth#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump ruby-saml to 1.12 omniauth/omniauth-saml
1 participant
@ichdasich