Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(storefront): BCTHEME-142 Unnecessary heading on product cards #1768

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

yurytut1993
Copy link
Contributor

What?

We have product link wrapped in h4 tag which is unnecessary. It can be possible just to remove h4, but I decided to change h4 to span for saving style class which was setted on h4, and now it is setted on span.

Also I should mention that typography styles little bit changed after disabling h4. But we don't have heading already - so we don't need heading styles. I think it is correct - now product name link has similar typography styles with other links in cornerstone.

Tickets / Documentation

Ticket

Screenshots (if appropriate)

main page grid cards
grid_cards

compare page cards
compare_cards

brand page cards
brand_cards

@bigbot
Copy link

bigbot commented Aug 6, 2020

Autotagging @bigcommerce/storefront-team @davidchin

@BC-tymurbiedukhin BC-tymurbiedukhin merged commit 1033d53 into bigcommerce:master Aug 26, 2020
@rowleyaj
Copy link
Contributor

rowleyaj commented Sep 9, 2020

@yurytut1993 will this change have any impact on SEO due to the removal of headers from the page and no relative importance applied to the product names?

I haven't done much research but dropping headers which wrap product titles seems pretty significant

old article (2017) https://www.velsof.com/blog/search-engine-optimization/how-to-organize-the-header-tag-structure-on-an-ecommerce-site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants