feature(storefront): BCTHEME-142 Unnecessary heading on product cards #1768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We have product link wrapped in h4 tag which is unnecessary. It can be possible just to remove h4, but I decided to change h4 to span for saving style class which was setted on h4, and now it is setted on span.
Also I should mention that typography styles little bit changed after disabling h4. But we don't have heading already - so we don't need heading styles. I think it is correct - now product name link has similar typography styles with other links in cornerstone.
Tickets / Documentation
Ticket
Screenshots (if appropriate)
main page grid cards
compare page cards
brand page cards