fix(storefront): BCTHEME-1755 Videos added through the Product Editor have their thumbnails cropped compared to videos added through the page builder #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-yevhenii-buliuk
requested review from
yurytut1993,
bc-vlad-dlogush and
BC-krasnoshapka
… have their thumbnails cropped compared to videos added through the page builder
bc-yevhenii-buliuk
force-pushed
the
BCTHEME-1755
branch
from
13cd4c9 to
d9ad9fd
Compare
bc-vlad-dlogush
approved these changes
Jan 3, 2024
bc-azvierieva
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes video scale added by Control Panel
Tickets / Documentation
Screenshots / Videos (if appropriate)
before:
1755_bug.mov
after:
1755_fix.mov