Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-1755 Videos added through the Product Editor have their thumbnails cropped compared to videos added through the page builder #2413

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix(storefront): BCTHEME-1755 Videos added through the Product Editor have their thumbnails cropped compared to videos added through the page builder #2413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9ad9fd
fix(storefront): BCTHEME-1755 Videos added through the Product Editor…
Jan 2, 2024
41d4f20
Merge branch 'master' into BCTHEME-1755
bc-yevhenii-buliuk Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Replace Twitter logo with X logo within social sharing and social link components [#2387](https://github.com/bigcommerce/cornerstone/pull/2387)
- Added nvm config [#2389](https://github.com/bigcommerce/cornerstone/pull/2389)
- Displaying the Hidden cart_order_source Input Field on PDP page [#2392](https://github.com/bigcommerce/cornerstone/pull/2392)
- Videos added through the Product Editor have their thumbnails cropped compared to videos added through the page builder [#2413](https://github.com/bigcommerce/cornerstone/pull/2413)
- Update Shop By Price Widget [#2408](https://github.com/bigcommerce/cornerstone/pull/2408)
- 'Please Select a file' popup forces shopper to re-upload file if the option type is 'File Upload' and is set to required [#2409](https://github.com/bigcommerce/cornerstone/pull/2409)
- Top Global Region Image Widget overlaps the mobile menu [#2402](https://github.com/bigcommerce/cornerstone/pull/2402)
Expand Down
7 changes: 7 additions & 0 deletions assets/scss/components/stencil/videoGallery/_videoGallery.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
// =============================================================================
// VIDEO GALLERY
// =============================================================================
//
// 1. Set padding-top to zero to overwrite the padding-top contained in the
// flex-video-container mixin, which affects the height of the video container
// and distorts the video scale.
//
// -----------------------------------------------------------------------------

.videoGallery-main {
@include flex-video-container();
margin-bottom: $videoGallery-spacing;
padding-top: 0; // 1
}

.videoGallery-list {
Expand Down
2 changes: 1 addition & 1 deletion templates/components/products/videos.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h4 class="toggle-title">
</h4>

<div class="toggle-content is-open" id="videoGallery-content">
<div class="videoGallery-main">
<div class="videoGallery-main widescreen">
<iframe
id="player"
class="lazyload"
Expand Down
Loading