fix(storefront): BCTHEME-1781 ADA Compliance - The Add to Cart modal dialog container is not labeled #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-yevhenii-buliuk
changed the title
bc-yevhenii-buliuk
requested review from
a team
and removed request for
a team
yurytut1993
reviewed
Feb 22, 2024
bc-yevhenii-buliuk
force-pushed
the
BCTHEME-1781
branch
from
87c682b to
f696e74
Compare
…dialog container is not labeled
bc-yevhenii-buliuk
force-pushed
the
BCTHEME-1781
branch
from
f696e74 to
7103f54
Compare
bc-yevhenii-buliuk
requested review from
a team and
yurytut1993
and removed request for
yurytut1993
bc-yevhenii-buliuk
requested review from
bc-vlad-dlogush,
bc-alexsaiannyi and
BC-krasnoshapka
bc-vlad-dlogush
approved these changes
Mar 1, 2024
bc-yevhenii-buliuk
requested review from
bc-azvierieva
and removed request for
BC-krasnoshapka
bc-azvierieva
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the appropriate aria attributes to Add to Cart modal dialog container.
Tickets / Documentation
Screen Recording
before changes:
1781__before.mov
after changes:
1781__after.mov