Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-1781 ADA Compliance - The Add to Cart modal dialog container is not labeled #2427

Merged
merged 4 commits into from
Mar 5, 2024
Merged

fix(storefront): BCTHEME-1781 ADA Compliance - The Add to Cart modal dialog container is not labeled #2427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7103f54
fix(storefront): BCTHEME-1781 ADA Compliance - The Add to Cart modal …
Feb 9, 2024
7083722
Merge branch 'master' into BCTHEME-1781
bc-yevhenii-buliuk Feb 28, 2024
2542c9a
Merge branch 'master' into BCTHEME-1781
bc-yevhenii-buliuk Mar 1, 2024
9fd1b66
Merge branch 'master' into BCTHEME-1781
bc-yevhenii-buliuk Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Decorative SVG elements should be hidden from screen reader users [#2432](https://github.com/bigcommerce/cornerstone/pull/2432)
- Content that functions as a list should be indicated as such to screen reader users [#2429](https://github.com/bigcommerce/cornerstone/pull/2429)
- ADA Compliance - The Add to Cart modal dialog container is not labeled [#2427](https://github.com/bigcommerce/cornerstone/pull/2427)
- ADA Compliance - Decorative SVG elements should be hidden from screen reader users [#2432](https://github.com/bigcommerce/cornerstone/pull/2432)
- ADA Compliance - Content that functions as a list should be indicated as such to screen reader users [#2429](https://github.com/bigcommerce/cornerstone/pull/2429)
- ADA Compliance - All form fields must be properly labeled [#2433](https://github.com/bigcommerce/cornerstone/pull/2433)
- ADA Compliance - Errors are not identified to screen reader users within the Refine By accordions [#2424](https://github.com/bigcommerce/cornerstone/pull/2424)
- ADA Compliance - Expandable items should be read by screen reader [2422](https://github.com/bigcommerce/cornerstone/pull/2422)
Expand Down
2 changes: 1 addition & 1 deletion templates/components/cart/preview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="modal-header">
<h1 class="modal-header-title">
<h1 id="modal-header-title" class="modal-header-title">
{{lang 'cart.added_to_cart.what_next' num_products=cart.quantity}}
</h1>
</div>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/products/product-view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,6 @@ <h2 class="productView-brand">

<div id="previewModal" class="modal modal--large" data-reveal>
{{> components/common/modal/modal-close-btn }}
<div class="modal-content"></div>
<div class="modal-content" role="dialog" aria-modal="true" aria-labelledby="modal-header-title"></div>
<div class="loadingOverlay"></div>
</div>
Loading