fix(storefront): BCTHEME-1779 Legion requires additional ARIA markup to assist screen reader users #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-vlad-dlogush
force-pushed
the
BCTHEME-1779
branch
from
365ffce to
00c345c
Compare
bc-vlad-dlogush
force-pushed
the
BCTHEME-1779
branch
from
00c345c to
237bc6d
Compare
bc-yevhenii-buliuk
approved these changes
Mar 1, 2024
yurytut1993
approved these changes
Mar 5, 2024
bc-alexsaiannyi
approved these changes
Mar 5, 2024
bc-azvierieva
suggested changes
Mar 6, 2024
…to assist screen reader users
bc-vlad-dlogush
force-pushed
the
BCTHEME-1779
branch
from
237bc6d to
bea8a47
Compare
bc-azvierieva
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds role=”region” and aria-label to help screen reader users in understanding what this section is for, and where it begins and ends. In order to meet WCAG 2.0 Level A.
Tickets / Documentation
Screenshots / Screen Recording
before.mov
after.mov