Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-1779 Legion requires additional ARIA markup to assist screen reader users #2435

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix(storefront): BCTHEME-1779 Legion requires additional ARIA markup to assist screen reader users #2435

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bea8a47
fix(storefront): BCTHEME-1779 Legion requires additional ARIA markup …
VladDlogush Feb 27, 2024
2293fd3
Merge branch 'master' into BCTHEME-1779
bc-vlad-dlogush Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Legion requires additional ARIA markup to assist screen reader users [#2435](https://github.com/bigcommerce/cornerstone/pull/2435)

## 6.13.0 (02-12-2024)
- Fix HTML markup for product listing and below content region [#2426](https://github.com/bigcommerce/cornerstone/pull/2426)
Expand Down
2 changes: 2 additions & 0 deletions lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@
},
"category": {
"label": "Categories",
"product_label": "Filtered products",
"shop_by_price": "Shop By Price",
"shop_by_price_range_aria": "Price range from {from} to {to}",
"filter_price_range": "Price range:",
Expand Down Expand Up @@ -870,6 +871,7 @@
"faceted": {
"selected": {
"title": "Refine by",
"facet-label": "Applied filters",
"rating-label": "Rated {rating, plural, one {# Star} other {# Stars}} Or More",
"no-filters": "No filters applied",
"clear-all": "Clear all"
Expand Down
2 changes: 1 addition & 1 deletion templates/components/category/product-listing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{{#if category.products}}
{{> components/products/filter sort=pagination.category.sort}}

<div data-list-name="Category: {{category.name}}">
<div data-list-name="Category: {{category.name}}" role="region" aria-label="{{lang 'category.product_label'}}">
{{#if theme_settings.product_list_display_mode '===' 'grid'}}
{{> components/products/grid products=category.products show_compare=category.show_compare theme_settings=theme_settings event="list" }}
{{else}}
Expand Down
2 changes: 1 addition & 1 deletion templates/components/faceted-search/selected-facets.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="facetedSearch-refineFilters sidebarBlock">
<div class="facetedSearch-refineFilters sidebarBlock" role="region" aria-label="{{lang 'search.faceted.selected.facet-label'}}">
<h2 class="sidebarBlock-heading">
{{lang 'search.faceted.selected.title'}}
</h2>
Expand Down