Skip to content

Commit

Permalink
feat(storefront): strf-10292 Node 18 Support (#1048) (#1058)
Browse files Browse the repository at this point in the history
  • Loading branch information
jairo-bc committed Mar 30, 2023
1 parent c754933 commit 48c912c
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pull_request_review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
build:
strategy:
matrix:
node: [16.x]
node: [16.x, 18.x]
os: ['ubuntu-latest', 'windows-2019', 'macos-latest']

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18.x'
- run: npm i
- name: Check Git Commit name
run: git log -1 --pretty=format:"%s" | npx commitlint
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.19
v18.13
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16
FROM node:18

WORKDIR /usr/src/app

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ The BigCommerce server emulator for local theme development.
## Install

Note: Stencil requires the Node.js runtime environment,
version 16.x is supported.
versions 16.x, 18.x are supported.

Run `npm install -g @bigcommerce/stencil-cli`.

Expand Down
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "CLI tool to run BigCommerce Stores locally for theme development.",
"main": "index.js",
"engines": {
"node": ">=16.0.0 <17.0.0",
"node": ">=16.0.0 <19.0.0",
"npm": ">=8.0.0 <10.0.0"
},
"scripts": {
Expand Down Expand Up @@ -48,7 +48,7 @@
],
"dependencies": {
"@bigcommerce/stencil-paper": "4.2.1",
"@bigcommerce/stencil-styles": "5.0.0",
"@bigcommerce/stencil-styles": "5.1.0",
"@hapi/boom": "^10.0.0",
"@hapi/glue": "^8.0.0",
"@hapi/h2o2": "^9.1.0",
Expand Down

0 comments on commit 48c912c

Please sign in to comment.