feat: STRF-10366 Node 18 Support #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-max
reviewed
Jan 20, 2023
package.json
Outdated
| @@ -4,8 +4,8 @@ | |||
| "description": "CLI tool to run BigCommerce Stores locally for theme development.", | |||
| "main": "index.js", | |||
| "engines": { | |||
| "node": ">=14.0.0 <15.0.0", | |||
| "npm": ">=v6.11.3 <9.0.0" | |||
| "node": ">=17.0.0 <19.0.0", | |||
There was a problem hiding this comment.
@jairo-bc your screen says that you've managed to run stencil on Node 14. Is that ok taking into account this line?
bc-max
previously approved these changes
Jan 20, 2023
jairo-bc
added a commit
to jairo-bc/stencil-cli
that referenced
this pull request
Mar 30, 2023
jairo-bc
added a commit
to jairo-bc/stencil-cli
that referenced
this pull request
Mar 30, 2023
jairo-bc
added a commit
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Node 18 Support
Tickets / Documentation
Screenshots (if appropriate)
cc @bigcommerce/storefront-team