Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overflow in IndelRealigner serialization #1190

Closed
fnothaft opened this issue Oct 1, 2016 · 0 comments
Closed

Fix stack overflow in IndelRealigner serialization #1190

fnothaft opened this issue Oct 1, 2016 · 0 comments
Assignees
Labels

Comments

@fnothaft
Copy link
Member

fnothaft commented Oct 1, 2016

95f3528 fixed the ZippedTargetSetSerializer, but not the TargetSetSerializer. For some reason, this fix worked OK on many files but not all. Not sure what the underlying change was... Something in Kryo/Spark?

@fnothaft fnothaft added the bug label Oct 1, 2016
@fnothaft fnothaft self-assigned this Oct 1, 2016
fnothaft added a commit to fnothaft/adam that referenced this issue Oct 1, 2016
Updates `org.bdgenomics.adam.rdd.read.realignment.TargetSetSerializer` to
manually (de)serialize each set element, instead of delegating to Kryo. This
eliminates a stack overflow from inside of Kryo. Resolves bigdatagenomics#1190.
heuermh pushed a commit that referenced this issue Oct 3, 2016
Updates `org.bdgenomics.adam.rdd.read.realignment.TargetSetSerializer` to
manually (de)serialize each set element, instead of delegating to Kryo. This
eliminates a stack overflow from inside of Kryo. Resolves #1190.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant