-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow open-ended intervals in loadIndexedBam #1196
Milestone
Comments
I've suggested before using Range from Guava, which handles bounded and unbounded ranges. It is well-designed and well-tested. I abuse it for genomics here https://github.com/heuermh/dishevelled-bio/tree/master/range/src/main/java/org/dishevelled/bio/range |
fnothaft
added a commit
to fnothaft/adam
that referenced
this issue
Nov 8, 2016
heuermh
pushed a commit
that referenced
this issue
Nov 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Intervals' start and end has to be specified in a ReferenceRegion before being passed to
loadIndexedBam
.It would be nice to allow intervals of the form
[N,∞)
without resorting to making callers useLong.MaxValue
or the like.The right model would be a sort of
ReferenceRegion
-precursor, shaped like(String, Long, Option[Long])
, that basically only exists ephemerally in the course of loading subsets of indexed BAMs.Guacamole has some code that does basically this here, allowing open-ended intervals, whole contigs, and "all" and "none" keywords, then resolving things into concrete
ReferenceRegion
s once contig-lengths are available, after parsing a BAM header.The text was updated successfully, but these errors were encountered: