Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bits of VariantContextConverter don't get ValidationStringencied #1371

Closed
fnothaft opened this issue Jan 24, 2017 · 2 comments
Closed

Bits of VariantContextConverter don't get ValidationStringencied #1371

fnothaft opened this issue Jan 24, 2017 · 2 comments
Assignees
@fnothaft
Labels
bug
Milestone
0.22.0

Comments

@fnothaft
Copy link
Member

E.g., https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/main/scala/org/bdgenomics/adam/converters/VariantContextConverter.scala#L1923 does not get a validation stringency check.
@fnothaft fnothaft added the bug label Jan 24, 2017
@fnothaft fnothaft added this to the 0.21.1 milestone Jan 24, 2017
@fnothaft fnothaft self-assigned this Jan 24, 2017
@heuermh
Copy link
Member

heuermh commented Jan 24, 2017

Now you've verbed it? We really need a better name :)

@fnothaft
Copy link
Member Author

Now you've verbed it? We really need a better name :)

In all fairness, I had slept very little at the point when I verbed it.

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 24, 2017
@fnothaft
[ADAM-1371] Wrap ADAM->htsjdk VariantContext conversion with validati…
f32f5a3 
…on stringency.

Resolves bigdatagenomics#1371.
@fnothaft fnothaft mentioned this issue Jan 24, 2017
Merged
fnothaft added a commit to fnothaft/adam that referenced this issue Mar 3, 2017
@fnothaft
[ADAM-1371] Wrap ADAM->htsjdk VariantContext conversion with validati…
521dab4 
…on stringency.

Resolves bigdatagenomics#1371.
heuermh pushed a commit that referenced this issue Mar 3, 2017
@fnothaft @heuermh
[ADAM-1371] Wrap ADAM->htsjdk VariantContext conversion with validati…
07c1982 
…on stringency.

Resolves #1371.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnothaft fnothaft

Labels
bug
Projects
None yet
Milestone
0.22.0
Development

No branches or pull requests
2 participants
@heuermh @fnothaft