Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to save GenomicRDDs after a join. #1576

Closed
devin-petersohn opened this issue Jun 21, 2017 · 0 comments
Closed

Unable to save GenomicRDDs after a join. #1576

devin-petersohn opened this issue Jun 21, 2017 · 0 comments
Milestone
0.23.0

Comments

@devin-petersohn
Copy link
Member

There are two things at work here:
1.) We are upcasting to GenomicRDD after a join, which does not have any save functionality attached.
2.) GenericGenomicRDD extends GenomicRDD, but does not have any save functionality attached.

I think it would be ok to create a GenomicRDD that is specific to the result joins and other set operations, mimicking the PairRDDFunctions in Spark. I don't see it as a problem for the user to be exposed to a GenomicPairRDD or something like that.

What type should a join return? How should we handle subsequent joins on a joined GenomicRDD?
fnothaft added a commit to fnothaft/adam that referenced this issue Jul 11, 2017
@fnothaft
[ADAM-1576] Allow translation between two different GenomicRDD types.
2b72fff 
Resolves bigdatagenomics#1576.
@fnothaft fnothaft mentioned this issue Jul 11, 2017
Merged
2 tasks
fnothaft added a commit to fnothaft/adam that referenced this issue Jul 11, 2017
@fnothaft
[ADAM-1576] Allow translation between two different GenomicRDD types.
f27ee3d 
Resolves bigdatagenomics#1576.
fnothaft added a commit to fnothaft/adam that referenced this issue Jul 12, 2017
@fnothaft
[ADAM-1576] Allow translation between two different GenomicRDD types.
e25d5a6 
Resolves bigdatagenomics#1576.
@fnothaft fnothaft added this to the 0.23.0 milestone Jul 12, 2017
fnothaft added a commit to fnothaft/adam that referenced this issue Jul 13, 2017
@fnothaft
[ADAM-1576] Allow translation between two different GenomicRDD types.
30a6119 
Resolves bigdatagenomics#1576.
fnothaft added a commit to fnothaft/adam that referenced this issue Jul 17, 2017
@fnothaft
[ADAM-1576] Allow translation between two different GenomicRDD types.
751da13 
Resolves bigdatagenomics#1576.
heuermh pushed a commit that referenced this issue Jul 17, 2017
@fnothaft @heuermh
[ADAM-1576] Allow translation between two different GenomicRDD types.
961f90a 
Resolves #1576.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

No branches or pull requests
2 participants
@fnothaft @devin-petersohn