Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputStream passed to VCFHeaderReader does not get closed #1900

Closed
fnothaft opened this issue Feb 3, 2018 · 0 comments
Closed

InputStream passed to VCFHeaderReader does not get closed #1900

fnothaft opened this issue Feb 3, 2018 · 0 comments
Assignees
@fnothaft
Labels
bug
Milestone
0.24.0

Comments

@fnothaft
Copy link
Member

fnothaft commented Feb 3, 2018

See https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/main/scala/org/bdgenomics/adam/rdd/ADAMContext.scala#L1153. This causes connection pool exhaustion when reading a large number of VCFs directly from S3.
@fnothaft fnothaft added the bug label Feb 3, 2018
@fnothaft fnothaft added this to the 0.24.0 milestone Feb 3, 2018
@fnothaft fnothaft self-assigned this Feb 3, 2018
fnothaft pushed a commit to fnothaft/adam that referenced this issue Feb 3, 2018
[ADAM-1900] Close stream after reading VCF header.
25002b5 
Resolves bigdatagenomics#1900.
@fnothaft fnothaft mentioned this issue Feb 3, 2018
Merged
heuermh pushed a commit that referenced this issue Feb 3, 2018
@heuermh
[ADAM-1900] Close stream after reading VCF header.
aa43a56 
Resolves #1900.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnothaft fnothaft

Labels
bug
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
1 participant
@fnothaft