-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phred values from 156–254 do not round trip properly between log space #1964
Comments
fnothaft
pushed a commit
to fnothaft/adam
that referenced
this issue
Mar 23, 2018
Resolves bigdatagenomics#1964. There was an underflow somewhere causing round trip from log space values to Phred to mismatch for values between 164 and 254. This change lowers the point where we switch from using the precomputed table to where we use the log math. Also, we add a unit test checking round trip values using PhredUtils.
fnothaft
pushed a commit
to fnothaft/adam
that referenced
this issue
Mar 23, 2018
Resolves bigdatagenomics#1964. There was an underflow somewhere causing round trip from log space values to Phred to mismatch for values between 164 and 254. This change lowers the point where we switch from using the precomputed table to where we use the log math. Also, we add a unit test checking round trip values using PhredUtils.
fnothaft
pushed a commit
to fnothaft/adam
that referenced
this issue
Mar 23, 2018
Resolves bigdatagenomics#1964. There was an underflow somewhere causing round trip from log space values to Phred to mismatch for values between 164 and 254. This change lowers the point where we switch from using the precomputed table to where we use the log math. Also, we add a unit test checking round trip values using PhredUtils.
heuermh
pushed a commit
that referenced
this issue
Mar 23, 2018
Resolves #1964. There was an underflow somewhere causing round trip from log space values to Phred to mismatch for values between 164 and 254. This change lowers the point where we switch from using the precomputed table to where we use the log math. Also, we add a unit test checking round trip values using PhredUtils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: