Improved README fix using feedback from other approach review. #1033
Conversation
|
Can one of the admins verify this patch? |
|
Jenkins, test this please. |
| .map(_.swap) | ||
| .sortByKey(ascending = false) | ||
| val kmers = reads. | ||
| flatMap(_.getSequence.sliding(21).map(k => (k, 1L))). |
There was a problem hiding this comment.
I believe this could be left out of the commit -- I don't see any code changes here, and the style doesn't match the Scala coding style used in ADAM.
|
Test PASSed. |
|
@heuermh so should I reformat the lines in question? - the only real fix was simply the import to get the implicit conversions working. |
|
@InvisibleTech if you wouldn't mind, that would be great! If you're short on time, I can reformat those lines and manually merge tomorrow. |
|
Sorry about not getting back to you - I assume you fixed the formatting issues. I have been apartment hunting as a part time job. |
|
No sweat, @InvisibleTech! I've just made the fix and merged this as 49e4bcf. Thanks for the PR, and best of luck with your apartment search! |
Took feedback from the other PR and used wildcard import to pick-up implicits needed to allow code sample shown in kmer.scala to work.