Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-602] Remove plugin code. #1065

Closed
wants to merge 1 commit into from

Conversation

fnothaft
Copy link
Member

@fnothaft fnothaft commented Jul 4, 2016

Resolves #602:

  • Removed the org.bdgenomics.adam.plugins package.
  • Removed the PluginExecutor command.
  • Removed the JavaADAMPlugin from the Java API.

Not so much a documentation update, but org.bdgenomics.adam.plugins was next on my documentation push, and I thought we had a ticket to remove it. CC @heuermh @tdanford because I can't remember if we had a consensus RE: removing plugins or not.

Resolves bigdatagenomics#602:

* Removed the `org.bdgenomics.adam.plugins` package.
* Removed the `PluginExecutor` command.
* Removed the `JavaADAMPlugin` from the Java API.
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1296/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented Jul 4, 2016

Some relevant discussion issue in #602. I'm still +1 to the general idea.

@heuermh
Copy link
Member

heuermh commented Jul 6, 2016

Merged commit e545d1a

Thank you, @fnothaft!

@heuermh heuermh closed this Jul 6, 2016
heuermh added a commit to heuermh/adam-plugins that referenced this pull request Jul 6, 2016
@tdanford
Copy link
Contributor

tdanford commented Jul 7, 2016

Retroactive +1.

@heuermh
Copy link
Member

heuermh commented Jul 7, 2016

Thanks, @tdanford! Sorry about being overly productive today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants