PR #1108 with issue #1122 #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| @@ -150,9 +150,25 @@ object ReferenceRegion { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Extracts ReferenceRegion from Feature | |||
There was a problem hiding this comment.
doc lines should be full sentences
|
LGTM, other than two small doc nits. I'm happy with how the feature <--> converage conversions worked out. |
fnothaft
force-pushed
the
issues/1122-remove-pairing-rdd
branch
from
cce9087
to
33ab795
Compare
|
Pulled in @akmorrow13 's latest changes, and rebased on master. |
|
@heuermh this resolves your comments. |
|
Test PASSed. |
|
Thank you, @fnothaft @akmorrow13! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @akmorrow13's PR #1108 with code tacked on to resolve #1122. @akmorrow13, I figured it might just be easier to do it this way. I rebased this on both ToT and your latest coverage branch, so it should be your latest and greatest coverage code.