Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAM-1188] Delete scripts/commit-pr.sh #1189

Merged
merged 1 commit into from
Oct 3, 2016
Merged

[ADAM-1188] Delete scripts/commit-pr.sh #1189

merged 1 commit into from
Oct 3, 2016

Conversation

fnothaft
Copy link
Member

Resolves #1188.

heuermh
heuermh approved these changes Sep 30, 2016
View reviewed changes
Copy link
Member

@heuermh heuermh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to note some dissenting opinion in this Hacker News thread
https://news.ycombinator.com/item?id=12581710

I'm still +1

@fnothaft
Copy link
Member Author

Thanks for the link @heuermh ! @hannes-ucsc and I were just discussing the CI point on the Toil scrum. I think that as long as they block unsafe rebases, the result is equivalent.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1511/
Test PASSed.

@heuermh heuermh merged commit dadfe1c into bigdatagenomics:master Oct 3, 2016
@heuermh
Copy link
Member

heuermh commented Oct 3, 2016

Thank you, @fnothaft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fnothaft @AmplabJenkins @heuermh