[ADAM-1280] Silence CRAM logging in tests. #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
Thank you, @fnothaft! |
|
The 1.8.2 parquet release may help (https://issues.apache.org/jira/browse/PARQUET-423). |
|
The 1.8.2 release is still a candidate, we're voting on it right now. PARQUET-423 is included in that release. |
|
Got it, thank you, @rdblue! Forgot about the Apache release process, I'll drop in on the dev@ mailing list to check out the release candidate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1280.
I tried for a while but couldn't silence the Parquet logging in the tests. We're still on Parquet 1.8.1, which messes with the Java util logging package, while Parquet 1.9.0 upgrades to Log4j. I figured that we'll punt on silencing the Parquet logs until we upgrade to 1.9.0, since that should then be a trivial fix.