Display Git commit info on command line

[smondet]

This is a first attempt at #41
(a “pick-me-up”).
To dump useful information while reporting bugs.

 $ java -jar adam-cli/target/adam-0.6.1-SNAPSHOT.jar buildinformation
Build information:
git.commit.id.abbrev: b476864
git.commit.message.full: Do code clean-up (BuildInformation)

git.commit.id: b476864265ee83660ea3cdb116241fb853720294
git.commit.message.short: Do code clean-up (BuildInformation)
git.commit.id.describe: adam-parent-0.6.0-69-gb476864
git.branch: git_properties
git.commit.time: 23.02.2014 @ 14:43:05 EST
git.remote.origin.url: git@github.com:bigdatagenomics/adam
git.build.time: 23.02.2014 @ 14:45:25 EST

It uses https://github.com/ktoso/maven-git-commit-id-plugin

[carlyeks]

Thanks for the great contribution, Sebastien!

I think we probably want this integrated in the adam-core (possibly in addition to adam-cli). A few use cases that will require this:

• If we annotate the Parquet files that are created, this will need to be accessed in the adam-core module
• If we are calling from a different repository, it would be good to know what the version of the library is that we are using

It would be nice to embed the version, and associated checking, in a method as well.

Also, could you rebase this down to a single commit? It's how we have been accepting new features.

[AmplabJenkins]

Can one of the admins verify this patch?

[massie]

Jenkins, please add to whitelist and test.

[AmplabJenkins]

One or more automated tests failed
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/153/

[massie]

Jenkins, retest this.

[massie]

maybe "buildinfo"? It would be shorter to type.

[massie]

Overall, this looks great. Thanks for the contribution, Sebastien!

Jenkins is having some issues running the tests but it's not related to your code. I'm tracking that down.

Just a few small nits about naming and exposing this info in the core module.

[smondet]

OK I will collapse the commits, change to buildinfo, and put the base code in a class in adam-core!

Thanks for the feedback

[tdanford]

Don't forget to rebase off of master too, before we merge.

[massie]

Jenkins, retest this.

[massie]

Jenkins, retest this please.

[AmplabJenkins]

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/157/

[massie]

All the tests are passing. This looks good. Once you make your changes, just push them to your git_properties branch to update this pull request.

Looking forward to getting this into ADAM. Thanks for the contribution, Sebastien.

[smondet]

Hi

Sorry for the delay, but here it is rebased :)

The object edu.berkeley.cs.amplab.adam.core.util.BuildInformation has two methods asMap and asString.

And the adam-cli command name is buildinfo.

Cheers

[arahuja]

The arguments are commented out here - are they needed? Do we need BuildInformationArgs?

[smondet]

I was seeing command line modules a bit like templates easy to fill-in in the future.

Bu if you think it's cleaner, I can try to remove it.

[fnothaft]

@arahuja I believe that a BuildInformationArgs class is required to be passed as a type parameter to the AdamSparkCommand class. However, this new functionality just inherits from an AdamCommand, so I don't think the argument class is needed. @smondet, I think it would be cleaner to remove the BuildInformationArgs class, as it is unused.

[smondet]

@fnothaft, OK done, and rebased :)

[AmplabJenkins]

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/187/

[AmplabJenkins]

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/ADAM-prb/196/

[fnothaft]

Merged—thank you @smondet!