Update README.md #139
Merged
Update README.md #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve the experience for users trying to build ADAM from source, I think it's worth explicitly adding the command to up the PermGen size and to turn off running tests, which should reduce the number of emails to the mailing list about failing builds and allow the new user to get moving with the jar file sooner rather than later. Feel free to discard if you think either change does more harm than good.
|
Can one of the admins verify this patch? |
|
I merged it -- it's just a change in documentation. :-) Thanks, Jeff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the experience for users trying to build ADAM from source, I think it's worth explicitly adding the command to up the PermGen size and to turn off running tests, which should reduce the number of emails to the mailing list about failing builds and allow the new user to get moving with the jar file sooner rather than later.
Feel free to discard if you think either change does more harm than good.