Converting some of the Option() calls to Some() #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… they can be converted. Carl and I ran into problems with this before, were the use of Option() actually broke other code, which was using an implicit ordering defined ... somewhere else now, I forget. (Carl, do you remember?)
|
Ah, yes! These changes make sense. I believe these updates are more idiomatic as well. |
fnothaft
added a commit
that referenced
this pull request
Dec 4, 2013
Converting some of the Option() calls to Some()
ryan-williams
added a commit
to ryan-williams/adam
that referenced
this pull request
Jun 20, 2017
upgrade plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... at least where it looks like they can be converted.
Carl and I ran into problems with this before, were the use of Option() actually broke other code, which was using an implicit ordering defined ... somewhere else now, I forget. (Carl, do you remember where this was?)
Unless I'm missing something Frank, and there's a specific reason to use the Option() syntax as-is?